-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intercept netplugin std error #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjj2wry
force-pushed
the
intercepte-stderr
branch
from
December 19, 2019 04:15
bdd126b
to
f715b72
Compare
Signed-off-by: 郑佳金 <zhengjiajin2016@gmail.com> Signed-off-by: 郑佳金 <zhengjiajin2016@gmail.com>
zjj2wry
force-pushed
the
intercepte-stderr
branch
from
December 19, 2019 06:09
f715b72
to
6f29b01
Compare
jellonek
approved these changes
Jan 8, 2020
/lgtm |
bboreham
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Actually, it looks like we would only get this if we called |
dcbw
added a commit
to dcbw/cri-o
that referenced
this pull request
Mar 6, 2020
…4161608-4fae32b84921 Specifically to get: containernetworking/cni#735 6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err But also pulls in some interface name validation and a compatibility fix for configurations that don't set a CNI version. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
added a commit
to dcbw/cri-o
that referenced
this pull request
Mar 6, 2020
…4161608-4fae32b84921 Specifically to get: containernetworking/cni#735 6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err But also pulls in some interface name validation and a compatibility fix for configurations that don't set a CNI version. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
added a commit
to dcbw/libpod
that referenced
this pull request
Mar 6, 2020
…4161608-4fae32b84921 Specifically to get: containernetworking/cni#735 6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err But also pulls in some interface name validation and a compatibility fix for configurations that don't set a CNI version. Signed-off-by: Dan Williams <dcbw@redhat.com>
snj33v
pushed a commit
to snj33v/libpod
that referenced
this pull request
May 31, 2020
…4161608-4fae32b84921 Specifically to get: containernetworking/cni#735 6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err But also pulls in some interface name validation and a compatibility fix for configurations that don't set a CNI version. Signed-off-by: Dan Williams <dcbw@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #732