Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intercept netplugin std error #735

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

zjj2wry
Copy link
Contributor

@zjj2wry zjj2wry commented Dec 19, 2019

fixes #732

Signed-off-by: 郑佳金 <zhengjiajin2016@gmail.com>
Signed-off-by: 郑佳金 <zhengjiajin2016@gmail.com>
@dcbw
Copy link
Member

dcbw commented Jan 8, 2020

/lgtm

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jellonek jellonek merged commit 6680f87 into containernetworking:master Jan 8, 2020
@bboreham
Copy link
Contributor

bboreham commented Jan 8, 2020

Actually, it looks like we would only get this if we called Output() on the command rather than Run(). @zjj2wry did you test this?

dcbw added a commit to dcbw/cri-o that referenced this pull request Mar 6, 2020
…4161608-4fae32b84921

Specifically to get:

containernetworking/cni#735
6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err

But also pulls in some interface name validation and a compatibility
fix for configurations that don't set a CNI version.

Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw added a commit to dcbw/cri-o that referenced this pull request Mar 6, 2020
…4161608-4fae32b84921

Specifically to get:

containernetworking/cni#735
6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err

But also pulls in some interface name validation and a compatibility
fix for configurations that don't set a CNI version.

Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw added a commit to dcbw/libpod that referenced this pull request Mar 6, 2020
…4161608-4fae32b84921

Specifically to get:

containernetworking/cni#735
6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err

But also pulls in some interface name validation and a compatibility
fix for configurations that don't set a CNI version.

Signed-off-by: Dan Williams <dcbw@redhat.com>
snj33v pushed a commit to snj33v/libpod that referenced this pull request May 31, 2020
…4161608-4fae32b84921

Specifically to get:

containernetworking/cni#735
6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err

But also pulls in some interface name validation and a compatibility
fix for configurations that don't set a CNI version.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if plugin segfaults/panics, invoke.ExecPlugin... claims it "failed with no error message"
4 participants