Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update github.com/containernetworking/cni to v0.7.2-0.20200304161608-4fae32b84921 #5414

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Mar 6, 2020

Specifically to get:

containernetworking/cni#735
6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err

But also pulls in some interface name validation and a compatibility
fix for configurations that don't set a CNI version.

Signed-off-by: Dan Williams dcbw@redhat.com

@dcbw
Copy link
Contributor Author

dcbw commented Mar 6, 2020

@haircommander

…4161608-4fae32b84921

Specifically to get:

containernetworking/cni#735
6f29b0165883b2b52ccd4dcb937162ea4c86927b intercept netplugin std err

But also pulls in some interface name validation and a compatibility
fix for configurations that don't set a CNI version.

Signed-off-by: Dan Williams <dcbw@redhat.com>
@mheon
Copy link
Member

mheon commented Mar 6, 2020

/approve

@mheon
Copy link
Member

mheon commented Mar 6, 2020

LGTM once tests go green

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@dcbw
Copy link
Contributor Author

dcbw commented Mar 6, 2020

@mheon tests are green :)

@mheon
Copy link
Member

mheon commented Mar 6, 2020

@baude @rhatdan @TomSweeneyRedHat @vrothberg @giuseppe PTAL and merge

@haircommander
Copy link
Collaborator

/lgtm

👼

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit b0d350a into containers:master Mar 6, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants