Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, upgrades and improvements #139

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fixes, upgrades and improvements #139

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bfbb97
Fixes, upgrades and improvements
sneridagh Apr 3, 2024
1d6a627
Fix tests
sneridagh Apr 3, 2024
2b340e4
Apply suggestions from code review
sneridagh Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
  • Loading branch information
@sneridagh @stevepiercy
sneridagh and stevepiercy authored Apr 4, 2024
commit 2b340e4f02627acebaf92522f8162dd0ee948247
6 changes: 4 additions & 2 deletions {{ cookiecutter.project_slug }}/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,16 @@ start-test-acceptance-frontend-dev: ## Start the Acceptance Frontend Fixture in

.PHONY: start-test-acceptance-server
start-test-acceptance-server: build-acceptance-servers ## Start Backend Acceptance Servers in development mode
@echo "Start acceptance backend"
@echo "Starting test acceptance server"
@docker run --rm -p 55001:55001 --name {{ cookiecutter.project_slug }}-backend-acceptance -d {{ cookiecutter.github_organization }}/{{ cookiecutter.project_slug }}-backend:acceptance
@echo "Started test acceptance server"

sneridagh marked this conversation as resolved.
Show resolved Hide resolved
.PHONY: test-acceptance
test-acceptance: ## Start Cypress (for use it while developing)
(cd frontend && ./node_modules/.bin/cypress open')

.PHONY: stop-acceptance-server
stop-acceptance-server: ## Stop Backend Acceptance Server in development mode
@echo "Stop backend acceptance container"
@echo "Stopping acceptance server"
@docker stop {{ cookiecutter.project_slug }}-backend-acceptance
sneridagh marked this conversation as resolved.
Show resolved Hide resolved
@echo "Stopped acceptance server"
Loading