Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, upgrades and improvements #139

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fixes, upgrades and improvements #139

merged 3 commits into from
Apr 23, 2024

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, overdue, improvement.

Just a remark. I ever wondered why "start cypress testing UI" is called (make) "test-acceptance". But this is obviously now a common parlance.

[EDIT] jargon -> parlance
Sorry, bad translation of a neutral german word to an english word with negative connotation.

@sneridagh
Copy link
Member Author

@ksuess Erico and I, we are planning to unify naming (and documenting it properly) through all Volto things during the Mexico sprint. So we will improve it soon.

@ksuess
Copy link
Member

ksuess commented Apr 3, 2024

@ksuess Erico and I, we are planning to unify naming (and documenting it properly) through all Volto things during the Mexico sprint. So we will improve it soon.

May I thank you with swiss chocolate?

@ksuess
Copy link
Member

ksuess commented Apr 3, 2024

Very nice, overdue, improvement.

Just a remark. I ever wondered why "start cypress testing UI" is called (make) "test-acceptance". But this is obviously now a common parlance.

[EDIT] jargon -> parlance
Sorry, jargon was a bad translation of a neutral german word to an english word with negative connotation. I changed it.

@sneridagh
Copy link
Member Author

@ksuess chocolate is always welcome! :)

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the messages with the command, and added its complement, to assist with troubleshooting if the docker command fails.

{{ cookiecutter.project_slug }}/Makefile Outdated Show resolved Hide resolved
{{ cookiecutter.project_slug }}/Makefile Show resolved Hide resolved
{{ cookiecutter.project_slug }}/Makefile Outdated Show resolved Hide resolved
{{ cookiecutter.project_slug }}/Makefile Show resolved Hide resolved
@stevepiercy
Copy link
Member

@ksuess Erico and I, we are planning to unify naming (and documenting it properly) through all Volto things during the Mexico sprint. So we will improve it soon.

I will be there, too, and I will give feedback from a newcomer perspective.

Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredvd fredvd merged commit 0f6bfdd into main Apr 23, 2024
5 checks passed
@fredvd fredvd deleted the updatesandimprovementsapr24 branch April 23, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants