-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes, upgrades and improvements #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, overdue, improvement.
Just a remark. I ever wondered why "start cypress testing UI" is called (make) "test-acceptance". But this is obviously now a common parlance.
[EDIT] jargon -> parlance
Sorry, bad translation of a neutral german word to an english word with negative connotation.
@ksuess Erico and I, we are planning to unify naming (and documenting it properly) through all Volto things during the Mexico sprint. So we will improve it soon. |
May I thank you with swiss chocolate? |
[EDIT] jargon -> parlance |
@ksuess chocolate is always welcome! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the messages with the command, and added its complement, to assist with troubleshooting if the docker command fails.
I will be there, too, and I will give feedback from a newcomer perspective. |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.