[ci] Bump to JDK 21 #4632
Merged
[ci] Bump to JDK 21 #4632
+11
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
sequencer
added
the
Dependency Update
|
I think this pump is OK. If there are something concerned, for example the jvm version is too new, we can downgrade it to 17. |
sequencer
added
Please Merge
sequencer
approved these changes
Jan 20, 2025
Comment on lines
-52
to
-55
| // Older versions of Scala do not work with newer versions of the JVM | ||
| // This is a hack to ensure we always use Java 8 to publish Chisel with Scala 2.13 | ||
| // We could use Java 11 with -release 8 | ||
| // Note that this target is used by real publishing but not by publishLocal |
There was a problem hiding this comment.
I think we don't need to support older version of Scala, bumping Scala version is always safe. Feel free to revert it.
|
Let's see if the release flow is passed. If not, @unlsycn please remove the older version of Scala. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #4616 and should fix #4616 (comment) as Mill has dropped support for Java 8 since 0.12(Changelog).
cc @seldridge @jackkoenig
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.