-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to src/test/scala-2 #4607
base: main
Are you sure you want to change the base?
Conversation
491627c
to
7834b6b
Compare
Several tests fail:
Those all probably have hardcoded source locator paths. You can make the tests a little more flexible, but for at least a couple of tests in |
This may be a good candidate for FileCheck? |
7834b6b
to
ce8c00e
Compare
@adkian-sifive Same (or perhaps a subset) of tests are still failing |
We're working on getting tests running with Scala3 with a piecemeal approach, so as features get implemented or the tests get fixed we'll move things back to src/main/scala.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Tests moved to scala-2 directory to facilitate smoother Scala 3 development
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.