improve type handling for non-string annotation data #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkmartinjr
changed the title
colinmegill
approved these changes
Nov 26, 2018
| const cat = categoricalSelectionState[metadataField]; | ||
| const categoryCount = { | ||
| total: cat.numOptions, | ||
| on: _.reduce(cat.optionSelected, (res, cond) => (cond ? res + 1 : res), 0) |
There was a problem hiding this comment.
Hmm, feeling on might be a little bit obfuscated. Does it mean 'currentlySelected', or is it related to a handler for an event? Room for a better name or a comment here. Obvious what it's doing here after spending a minute reading the ternary, so maybe it's fine.
There was a problem hiding this comment.
will improve the clarity
csweaver
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
Several improvements to annotation/metadata handling:
While this fixes #457, there is still residual issues with how we summarize metadata in the front-end (specfically,
world.summaryassumes all annotation/metadata values can be safely converted to Object lables/strings without losing information). There will be another PR to fix that.