Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve locator type detection #969

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Improve locator type detection #969

merged 1 commit into from
Nov 30, 2020

Conversation

jkutner
Copy link
Member

@jkutner jkutner commented Nov 30, 2020

Summary

Added a check for . when testing if a URI contains a hostname

Output

N/A

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #968

Signed-off-by: Joe Kutner <jpkutner@gmail.com>
@jkutner jkutner requested a review from a team as a code owner November 30, 2020 19:56
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #969 (e9b854c) into main (f85ce47) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files         103      103           
  Lines        5006     5006           
=======================================
  Hits         3888     3888           
  Misses        724      724           
  Partials      394      394           
Flag Coverage Δ
os_linux 77.67% <100.00%> (ø)
os_macos 74.66% <100.00%> (ø)
os_windows 100.00% <ø> (?)
unit 77.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero jromero added the type/bug Issue that reports an unexpected behaviour. label Nov 30, 2020
@jromero jromero added this to the 0.16.0 milestone Nov 30, 2020
@jromero jromero merged commit 167bac5 into main Nov 30, 2020
@jromero jromero deleted the fix-968 branch November 30, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: pack build improperly infers buildpack type in 0.15
2 participants