Merge pull request #969 from buildpacks/fix-968

Improve locator type detection
buildpacks · Nov 30, 2020 · 167bac5 · 167bac5
2 parents f85ce47 + e9b854c
commit 167bac5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/internal/buildpack/locator_type.go b/internal/buildpack/locator_type.go
@@ -86,7 +86,7 @@ func builderMatchFound(locator string, candidates []dist.BuildpackInfo) bool {
 func hasHostPortPrefix(locator string) bool {
 	if strings.Contains(locator, "/") {
 		prefix := strings.Split(locator, "/")[0]
-		if strings.Contains(prefix, ":") {
+		if strings.Contains(prefix, ":") || strings.Contains(prefix, ".") {
 			return true
 		}
 	}

diff --git a/internal/buildpack/locator_type_test.go b/internal/buildpack/locator_type_test.go
@@ -157,6 +157,10 @@ func testGetLocatorType(t *testing.T, when spec.G, it spec.S) {
 			locator:      "localhost:1234/example/package-cnb",
 			expectedType: buildpack.PackageLocator,
 		},
+		{
+			locator:      "dev.local/http-go-fn:latest",
+			expectedType: buildpack.PackageLocator,
+		},
 	} {
 		tc := tc