Adding new style versions to special arguments #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, there is still one "arguments_file" literal embedded in a test case... |
|
Other than that it looks good (although see #123 for the last time we tried to do this). Also IIRC I think this affects Picard. |
lbergelson
force-pushed
the
lb_update_special_args
branch
from
a6e6e6d to
2bab65f
Compare
|
@cmnbroad I think we should merge this one. It keeps the old arguments around as an option, so it shouldn't hurt anyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@droazen @cmnbroad Making the special arguments consistent but leaving the old way for now.