Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: unset configMapAndSecretChangeDetectionStrategy #2166

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Jun 1, 2022

Issue number:
N/A

Description of changes:

    kubernetes: unset `configMapAndSecretChangeDetectionStrategy`
    
    We've carried this kubelet config setting since the beginning and it has
    become apparent that this causes significant pod start up delays.
    
    The default value for `configMapAndSecretChangeDetectionStrategy` is
    "watch" which seems appropriate for most use cases.

Testing done:
Applying a deployment of 300 nginx pods takes 1 min 30~ on two m5.8xlarge nodes. Where as before this change, it would have taken at least 3 mins:

$ time kubectl wait --for=condition=available --timeout=600s deployment/nginx-deployment
deployment.apps/nginx-deployment condition met

real    1m30.614s

Run some workloads with the following variants and their corresponding clusters

  • aws-k8s-1.19
  • aws-k8s-1.20
  • aws-k8s-1.21
  • aws-k8s-1.22
  • vmware-k8s-1.20
  • vmware-k8s-1.21
  • vmware-k8s-1.22

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We've carried this kubelet config setting since the beginning and it has
become apparent that this causes significant pod start up delays.

The default value for `configMapAndSecretChangeDetectionStrategy` is
"watch" which seems appropriate for most use cases.
@etungsten etungsten requested review from bcressey, cbgbt and gthao313 June 1, 2022 20:46
@etungsten etungsten marked this pull request as ready for review June 1, 2022 21:49
@etungsten etungsten merged commit 38cae84 into bottlerocket-os:develop Jun 2, 2022
@etungsten etungsten deleted the caches-to-watches branch June 2, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants