-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest containerd, runc, docker #2158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending testing. I'll also pull these commits into my own development branch to give them more exercise.
We should confirm that ulimit -n
in a pod returns 65k. It'd also be good to keep an eye on the runc 1.1.3 milestone to see if any regressions appear. The dbus fix there might be worth pulling in.
Thanks!
I've confirmed that the ulimit is appropriately set inside a kubernetes Pod running in this build of containerd!
Good tip. A lot of the existing testing for this build is in-flight, I'll complete it and then look into re-running some subset of testing with a patch for that runc issue in place. |
This includes a rebase of the rlimit patch.
Includes changes for both docker-engine and docker-cli.
It turns out that opencontainers/runc#3476 doesn't totally resolve the issue with dbus. Our Kubernetes build relies on a vendored version of runc for I've opened #2172 to track the issue. |
Issue number: #1971
Description of changes: This moves Bottlerocket to the latest versions of containerd, runc, and docker.
Testing done:
Our own changes are pretty small here, but testing for feature compatibility, performance, and regressions is critical. All testing has been done with a local build of the latest changes to the bottlerocket-sdk.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.