Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add methods intersect_plane and get_point to Ray #6179

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 54 additions & 1 deletion crates/bevy_math/src/ray.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,59 @@ use serde::{Deserialize, Serialize};
pub struct Ray {
/// The origin of the ray.
pub origin: Vec3,
/// The direction of the ray.
/// A normalized vector representing the direction of the ray.
pub direction: Vec3,
}

impl Ray {
/// Returns the distance to the plane if the ray intersects it.
#[inline]
pub fn intersect_plane(&self, plane_origin: Vec3, plane_normal: Vec3) -> Option<f32> {
let denominator = plane_normal.dot(self.direction);
if denominator.abs() > f32::EPSILON {
let distance = (plane_origin - self.origin).dot(plane_normal) / denominator;
if distance >= f32::EPSILON {
return Some(distance);
}
}
None
}

/// Retrieve a point at the given distance along the ray.
#[inline]
pub fn get_point(&self, distance: f32) -> Vec3 {
self.origin + self.direction * distance
}
}

#[cfg(test)]
mod test {
use super::*;

#[test]
fn intersects_plane() {
let ray = Ray {
origin: Vec3::ZERO,
direction: Vec3::Z,
};

// Orthogonal, and test that plane_normal direction doesn't matter
assert_eq!(Some(1.), ray.intersect_plane(Vec3::Z, Vec3::Z));
assert_eq!(Some(1.), ray.intersect_plane(Vec3::Z, Vec3::NEG_Z));
assert_eq!(None, ray.intersect_plane(Vec3::NEG_Z, Vec3::Z));
assert_eq!(None, ray.intersect_plane(Vec3::NEG_Z, Vec3::NEG_Z));

// Diagonal
assert_eq!(Some(1.), ray.intersect_plane(Vec3::Z, Vec3::ONE));
assert_eq!(None, ray.intersect_plane(Vec3::NEG_Z, Vec3::ONE));

// Parralel
assert_eq!(None, ray.intersect_plane(Vec3::X, Vec3::X));

// Parralel with simulated rounding error
assert_eq!(
None,
ray.intersect_plane(Vec3::X, Vec3::X + Vec3::Z * f32::EPSILON)
);
}
}