[WIP] 7037 Abstract BlockingQueue#Offer Failure Handling #7052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinborromeo
changed the title
leventov
reviewed
Feb 12, 2019
| if (!success) { | ||
| log.warn("queue too slow!"); | ||
| } | ||
| statusQueueHelper.offerAndHandleFailure( |
There was a problem hiding this comment.
In the current form BlockingQueueHelper only increases the complexity of classes where it is used. It's too shallow.
I doubt it's reasonable to extract the pattern from all places across the codebase where it was found. What about abstracting it just in emitters? See #7057.
There was a problem hiding this comment.
Makes sense. I noticed the behaviour was fairly different between the provided examples so I used this abstraction to avoid changing behaviour. Does it make sense to close this issue/PR and focus on #7057?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7037
To abstract the logic of checking whether a
BlockingQueue#offer()call succeeded, I created a helper class that wraps theoffercall and executes a function (provided as an argument) if unsuccessful. I chose to implement the abstraction this way instead of a utility class with static methods so that the type of the offered element could be validated at compile time.