Use <button> not <input>s for form submission
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
added a commit
to alphagov/govuk-frontend
that referenced
this pull request
May 8, 2018
Only allow `input` to be used when explicitly asking to use it. See alphagov/govuk_elements#593
NickColley
approved these changes
May 8, 2018
Both `<button type='submit'>Submit<button>` and `<input type='submit' value='Submit'>` can be used to submit a form. Historically `<input>` has been preferred because it’s better-supported by IE6 in that: - the `submit` attribute is mandatory on `<button>`, not on `<input>` - the `innerHTML` of a button will be submitted to the server, not the value (as in other browsers) Reasons to now use `<button>` instead: - IE6/7 support is no longer a concern (especially with deprecation of TLS 1.0 on the way) - Because an `<input>` element can’t have children, the pseudo-element hack[1] used to ensure the top edge of the button is clickable doesn’t work. Fixes alphagov#545 1. alphagov/govuk_frontend_toolkit@24e1906#diff-ef0e4eb6f1e90b44b0c3fe39dce274a4R79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
<button type='submit'>Submit<button>and<input type='submit' value='Submit'>can be used to submit a form.Historically
<input>has been preferred because it’s better-supported by IE6 in that:submitattribute is mandatory on<button>, not on<input>innerHTMLof a button will be submitted to the server, not thevalue(as in other browsers)Reasons to now use
<button>instead:<input>element can’t have children, the pseudo-element hack1 used to ensure the top edge of the button is clickable doesn’t work.Fixes #545