Make button element the default instead of input for button macro
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only allow `input` to be used when explicitly asking to use it. See alphagov/govuk_elements#593
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-683
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-683
NickColley
force-pushed
the
change-button-default-from-input
branch
from
a5c9973 to
d2e30f6
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-683
NickColley
changed the title
button element the default instead of input for button macro
NickColley
force-pushed
the
change-button-default-from-input
branch
from
d2e30f6 to
b6bc491
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-683
kr8n3r
reviewed
May 9, 2018
CHANGELOG.md
Outdated
| @@ -23,6 +23,10 @@ Breaking change: | |||
| to a more consise naming structure. We have also introduced two mixins | |||
| to help generate additional or custom grid styles and widths. | |||
|
|
|||
| - Make `button` element the default instead of `input` for button macro #683 | |||
NickColley
force-pushed
the
change-button-default-from-input
branch
from
b6bc491 to
ca9813a
Compare
kr8n3r
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are making
buttonthe default, however since thebuttonelement is buggy in IE6 / IE7, we are allowing input to be used if required.Thanks @quis for the original issue on GOV.UK Elements :)
Context: alphagov/govuk_elements#593
Trello: https://trello.com/c/gITiuXcS/765-use-button-by-default-for-buttons-rather-than-input-typebutton