Merge pull request #138 from alphagov/do-not-report-exceptions-rescue…

…d-by-ActionDispatch

Do not report exceptions rescued by rails

CHANGELOG.md

@@ -1,3 +1,7 @@
+# Unreleased
+
+* Stop exceptions rescued by rails from appearing in Sentry (/~https://github.com/alphagov/govuk_app_config/pull/138)
+
 # 2.0.3
 
 * Add hmrc-uk.digital.nuance.com (Nuance/HMRC Webchat provider) and gov.klick2contact.com (HMPO web chat provider) to connect-src CSP list (/~https://github.com/alphagov/govuk_app_config/pull/133)

lib/govuk_app_config/configure.rb

@@ -8,16 +8,9 @@
   config.silence_ready = !Rails.env.production? if defined?(Rails)
 
   config.excluded_exceptions = [
-    'AbstractController::ActionNotFound',
-    'ActionController::BadRequest',
-    'ActionController::InvalidAuthenticityToken',
-    'ActionController::ParameterMissing',
-    'ActionController::RoutingError',
     'ActionController::UnknownAction',
-    'ActionController::UnknownHttpMethod',
     'ActionDispatch::RemoteIp::IpSpoofAttackError',
     'ActiveJob::DeserializationError',
-    'ActiveRecord::RecordNotFound',
     'CGI::Session::CookieStore::TamperedWithCookie',
     'GdsApi::HTTPIntermittentServerError',
     'GdsApi::TimedOutException',
@@ -33,4 +26,8 @@
   config.transport_failure_callback = Proc.new {
     GovukStatsd.increment("error_reports_failed")
   }
+
+  # This stops exceptions rescued by rails from appearing in Sentry.
+  # See https://www.rubydoc.info/gems/sentry-raven/1.2.2/Raven%2FConfiguration:rails_report_rescued_exceptions
+  config.rails_report_rescued_exceptions = false
 end