Skip to content

Commit

Permalink
Remove redundant exclusions
Browse files Browse the repository at this point in the history
Setting `config.rails_report_rescued_exceptions` to `false` makes having
these exceptions in `config.excluded_exceptions` redundant.

All the exceptions present in `config.action_dispatch.rescue_responses`
can be removed from `config.excluded_exceptions`.

See
https://guides.rubyonrails.org/configuring.html#configuring-action-dispatch
for the list of exceptions in `config.action_dispatch.rescue_responses`.

Trello card: https://trello.com/c/Ik7ulDXQ/1768-3-upgrade-frontend-to-rails-6
  • Loading branch information
Alan Gabbianelli committed Mar 9, 2020
1 parent f8e1234 commit 8f25109
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions lib/govuk_app_config/configure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,9 @@
config.silence_ready = !Rails.env.production? if defined?(Rails)

config.excluded_exceptions = [
'AbstractController::ActionNotFound',
'ActionController::BadRequest',
'ActionController::InvalidAuthenticityToken',
'ActionController::ParameterMissing',
'ActionController::RoutingError',
'ActionController::UnknownAction',
'ActionController::UnknownHttpMethod',
'ActionDispatch::RemoteIp::IpSpoofAttackError',
'ActiveJob::DeserializationError',
'ActiveRecord::RecordNotFound',
'CGI::Session::CookieStore::TamperedWithCookie',
'GdsApi::HTTPIntermittentServerError',
'GdsApi::TimedOutException',
Expand Down

0 comments on commit 8f25109

Please sign in to comment.