Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Generate ID and ObjectType Show Object Methods #3292

Merged
merged 48 commits into from
Jan 9, 2025

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

Changes

  • added generating ID() and ObjectType() helper methods

Examples

Generated examples for:
SchemaObjectIdentifier

  • secrets
  • streamlits

AccountObjectIdentifier

  • api_integrations
  • notificatoin_integrations

@sfc-gh-fbudzynski sfc-gh-fbudzynski changed the base branch from main to dev December 16, 2024 09:15
@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as ready for review December 16, 2024 09:19
@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as draft December 16, 2024 09:20
@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as ready for review December 16, 2024 09:37
Copy link

Integration tests failure for 38b8a3e322265c1b53426416e494dade4b2d54b5

Copy link

Integration tests failure for 9f29c422c3fb2175fcdcd555a6b47c010a02a993

pkg/sdk/poc/generator/helper_methods.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/helper_methods.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/helper_methods.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/helper_methods.go Outdated Show resolved Hide resolved
@sfc-gh-fbudzynski sfc-gh-fbudzynski changed the title chore: Generate ID and ObjectType Methods chore: Generate ID and ObjectType Show Object Methods Dec 18, 2024
Copy link

Integration tests failure for c60dec58a0f43da3e9bf4126eb358889ca0c101e

Copy link

Integration tests failure for a9d50cb6fd168a1818d4e2038ff268f7edc1c413

Copy link

Integration tests failure for 57ebbc34fb17754d7e0e1ab7df9a62ad02ea4dfe

Copy link

Integration tests failure for 560cc8b84fbd42697bf5d898308ea91743b01918

pkg/sdk/poc/generator/operation.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/templates/show_object_method.tmpl Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 5f5e26326b475687677b11f7a579267e8b173113

Copy link

Integration tests failure for cae24f6f5b8bbf68767e342ef07bbee9df13c0ce

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 8, 2025 13:01
Copy link

github-actions bot commented Jan 8, 2025

Integration tests failure for 52f603ae2ee460b1572c4d8b936db8e4dc65bde7

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 9, 2025 09:35
@sfc-gh-asawicki sfc-gh-asawicki merged commit 1323cda into dev Jan 9, 2025
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the sdk-helper-methods branch January 9, 2025 13:39
sfc-gh-jcieslak pushed a commit that referenced this pull request Jan 20, 2025
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
## Changes
* added generating ID() and ObjectType() helper methods

## Examples
Generated examples for:
**SchemaObjectIdentifier**
* secrets
* streamlits

**AccountObjectIdentifier**
* api_integrations
* notificatoin_integrations
sfc-gh-jcieslak pushed a commit that referenced this pull request Jan 20, 2025
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
## Changes
* added generating ID() and ObjectType() helper methods

## Examples
Generated examples for:
**SchemaObjectIdentifier**
* secrets
* streamlits

**AccountObjectIdentifier**
* api_integrations
* notificatoin_integrations
sfc-gh-jcieslak pushed a commit that referenced this pull request Jan 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.0.2](v1.0.1...v1.0.2)
(2025-01-20)


### 🔧 **Misc**

* Generate ID and ObjectType Show Object Methods
([#3292](#3292))
([f7ff70a](f7ff70a))
* Generate multiline by default
([#3315](#3315))
([520bb4c](520bb4c))
* Overview of the grant ownership resource
([#3342](#3342))
([9f891d6](9f891d6))
* Update docs and migration guide
([#3313](#3313))
([59e333a](59e333a))


### 🐛 **Bug fixes:**

* Fixes in account parameters
([#3310](#3310))
([96a1f17](96a1f17))
* Handle optional account fields in the state upgrader correctly
([#3330](#3330))
([4eae4c8](4eae4c8)),
closes
[#3332](#3332)
* Small fixes
([#3337](#3337))
([8807839](8807839))

---
This PR was generated with [Release
Please](/~https://github.com/googleapis/release-please). See
[documentation](/~https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants