Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2140 A more maintainable setup.py (WIP) #2221

Closed
wants to merge 78 commits into from
Closed

2140 A more maintainable setup.py (WIP) #2221

wants to merge 78 commits into from

Conversation

lucas-wilkins
Copy link
Contributor

No description provided.

lucas-wilkins and others added 30 commits August 19, 2022 11:50
@lucas-wilkins
Draft of config class
ad96e57
@lucas-wilkins
Initial part of migration to temporary config
2e9a9a1
@lucas-wilkins
Merge branch 'main' into 2164-update-config-from-list-of-variables-to…
f0a0e95 
…-class
@lucas-wilkins
Reverted file name
2dd219b
@lucas-wilkins
Some migration to config object
64d6659
@lucas-wilkins
More migration
32d2ab1
@lucas-wilkins
Undid erronious substitutions: config -> config_system
a5962b5
@lucas-wilkins
Added tempory package to setup.py
b04b370
@lucas-wilkins
Removed local_config.py
19b3fd6
@lucas-wilkins
Merge branch 'main' into 2164-update-config-from-list-of-variables-to…
d455208 
…-class
@lucas-wilkins
Removed some references to local_config.py
1dc5e60
@lucas-wilkins
Removed custom_config.py
7047c29
@lucas-wilkins
Removed custom_config from spec
314e93d
@lucas-wilkins
Replaced references to custom_config
b490e5c
@lucas-wilkins
Adding schema system to config
2e3ba48
@lucas-wilkins
Unit tests for config class, start of load/save
a7578e4
@lucas-wilkins
load and save implemented, tests pass
eb93ad1
@lucas-wilkins
Config saved to config.json on exit, a decision needs to be made abou…
3b4566c 
…t where this should be in future
@lucas-wilkins
Fixed issue with test values that should be different for defaults no…
96b1dee 
…t being so
@lucas-wilkins
Used config copies in config, not the main config item as this appear…
c2d028a 
…s to affect tests
@lucas-wilkins
Merge branch 'main' into 2164-update-config-from-list-of-variables-to…
3081952 
…-class
@lucas-wilkins
Removed installer_generator files
41fed40
@lucas-wilkins
Removed another local config
a32de61
@lucas-wilkins
Removed unused text from config
6fe1f67
@lucas-wilkins
Preparing for migration of urls
6b7d9ef
@lucas-wilkins
Removed unused methods from __init__
906ec91
@lucas-wilkins
Introduced url container
a2c7602
@lucas-wilkins
Factored out urls
6182c35
@lucas-wilkins
More deletions of unused fields
7f63860
@lucas-wilkins
Removed more unused fields from config
0b95f6a
@lucas-wilkins
Fixed bad imports in utest
741febe
@lucas-wilkins
Updated .gitignore to miss config.json
e3c41e0
@lucas-wilkins
Cleaned up __init__s, made user, version, and zenodo files in system
0c9fba3
@lucas-wilkins
Update release automation script for new structure
c18428a
@lucas-wilkins
Removed commented datas
93cb3bc
@lucas-wilkins
Cleaning up GuiUtils
db8ef64
@lucas-wilkins
Cleaned some of GuiUtils and removed more config entries
92da71d
@lucas-wilkins
Removed CustomDir.py
c9a070d
@lucas-wilkins
Update web links
4780943
@lucas-wilkins
Fixed build number issues
b7a6b2e
@lucas-wilkins
Fixed version location in setup
69d1d95
@lucas-wilkins
Removed hide toolbar text
6b6527a
@lucas-wilkins
Fixed version
7ca5d50
@lucas-wilkins
Delft URL
576eacc
@lucas-wilkins
Moved sas.system.user import
6656884
@lucas-wilkins
Changed import again
38957fe
@lucas-wilkins
Removed strict version requirement - isn't really necessary
ea5ce84
@lucas-wilkins
Attempt to fix images issue
a6f2339
@lucas-wilkins
Merge branch '2164-update-config-from-list-of-variables-to-class' int…
5620a28 
…o 2140-a-more-maintainable-setuppy
@lucas-wilkins
Testing different ways of locating packages
07fb48a
@lucas-wilkins lucas-wilkins linked an issue Sep 26, 2022 that may be closed by this pull request
A more maintainable setup.py #2140
Closed
@llimeht
Copy link
Contributor

llimeht commented Sep 27, 2022

I was curious to see the setup.py changes but I see they're entangled in rather a lot of other changes. I assume the plan is to land some other PRs and then rebase this work?

(The reason I was keen to look at the setup.py changes was that I was rather hoping that it would actually go away to be instead replaced by a PEP517 builder with a declarative config file rather than an executable one...)

@lucas-wilkins
Copy link
Contributor Author

I was curious to see the setup.py changes but I see they're entangled in rather a lot of other changes. I assume the plan is to land some other PRs and then rebase this work?

Yeah, its based on #2164 which is not yet merged.

(The reason I was keen to look at the setup.py changes was that I was rather hoping that it would actually go away to be instead replaced by a PEP517 builder with a declarative config file rather than an executable one...)

I was just going to make it so that you didn't have to manually change entries in it whenever you rename a file. There are reasons why the executable will need to remain, for now. Maybe I'll raise this today at the call.

@wpotrzebowski wpotrzebowski added Discuss At The Call Issues to be discussed at the fortnightly call and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Oct 10, 2022
@lucas-wilkins
Copy link
Contributor Author

Closing this for now. Going to make a discussion topic about it.

@lucas-wilkins lucas-wilkins deleted the 2140-a-more-maintainable-setuppy branch November 8, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A more maintainable setup.py
3 participants
@lucas-wilkins @llimeht @wpotrzebowski