Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more maintainable setup.py #2140

Closed
lucas-wilkins opened this issue Aug 11, 2022 · 6 comments
Closed

A more maintainable setup.py #2140

lucas-wilkins opened this issue Aug 11, 2022 · 6 comments
Assignees
Labels
Blocked Issues that are blocked by something Enhancement Feature requests and/or general improvements Infrastructure GitHub, project structure, community etc

Comments

@lucas-wilkins
Copy link
Contributor

After forgetting to add a new directory I created to setup.py, and looking at the issues it has if package names are not properly entered, I wonder if would it make more sense to just recursively search the source tree and add everything automatically, rather than having to explicitly maintain a list of the packages we want to include?

Is this something that should be done? Perhaps there a reason why it is currently done the way it is.

@lucas-wilkins lucas-wilkins added Infrastructure GitHub, project structure, community etc Discuss At The Call Issues to be discussed at the fortnightly call labels Aug 11, 2022
@krzywon
Copy link
Contributor

krzywon commented Aug 11, 2022

In the same regard, we should talk about bundling our workflow ymls so we don't miss dependencies. The html2text dependency (adding it to #2139 shortly) is currently only in the release yml.

@krzywon
Copy link
Contributor

krzywon commented Aug 11, 2022

To add to my previous comment, most of the workflow steps overlap each other. We should be able to combine installers, test, and docs into a single workflow.

@lucas-wilkins
Copy link
Contributor Author

The html2text dependency (adding it to #2139 shortly) is currently only in the release yml.

I thought we decided to only maintain release.yml - am I wrong about this? - anyway, I think this highlights the issue quite well.

@krzywon
Copy link
Contributor

krzywon commented Aug 11, 2022

I thought we decided to only maintain release.yml - am I wrong about this? - anyway, I think this highlights the issue quite well.

I don't know, TBH. What I do know is installers.yml is what generates the test executables for branches and PRs. release.yml is what is used to generate the executables attached to releases. Releases typically use a pinned version of sasmodels, and often for bumps as well, instead of master branches.

@lucas-wilkins lucas-wilkins pinned this issue Aug 11, 2022
@lucas-wilkins
Copy link
Contributor Author

I don't know, TBH. What I do know is installers.yml is what generates the test executables for branches and PRs.

o_O

release.yml is what is used to generate the executables attached to releases. Releases typically use a pinned version of sasmodels, and often for bumps as well, instead of master branches.

Yeah

@lucas-wilkins lucas-wilkins unpinned this issue Aug 16, 2022
@lucas-wilkins lucas-wilkins added Feature Request and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Aug 17, 2022
@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements and removed Feature Request labels Aug 31, 2022
@lucas-wilkins lucas-wilkins self-assigned this Sep 14, 2022
@lucas-wilkins lucas-wilkins linked a pull request Sep 26, 2022 that will close this issue
@lucas-wilkins lucas-wilkins added Discuss At The Call Issues to be discussed at the fortnightly call Blocked Issues that are blocked by something labels Sep 27, 2022
@butlerpd butlerpd removed the Discuss At The Call Issues to be discussed at the fortnightly call label Feb 12, 2023
@lucas-wilkins
Copy link
Contributor Author

This has been done via #2419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked by something Enhancement Feature requests and/or general improvements Infrastructure GitHub, project structure, community etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants