-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A more maintainable setup.py #2140
Comments
In the same regard, we should talk about bundling our workflow ymls so we don't miss dependencies. The html2text dependency (adding it to #2139 shortly) is currently only in the release yml. |
To add to my previous comment, most of the workflow steps overlap each other. We should be able to combine installers, test, and docs into a single workflow. |
I thought we decided to only maintain release.yml - am I wrong about this? - anyway, I think this highlights the issue quite well. |
I don't know, TBH. What I do know is installers.yml is what generates the test executables for branches and PRs. release.yml is what is used to generate the executables attached to releases. Releases typically use a pinned version of sasmodels, and often for bumps as well, instead of master branches. |
o_O
Yeah |
This has been done via #2419 |
After forgetting to add a new directory I created to setup.py, and looking at the issues it has if package names are not properly entered, I wonder if would it make more sense to just recursively search the source tree and add everything automatically, rather than having to explicitly maintain a list of the packages we want to include?
Is this something that should be done? Perhaps there a reason why it is currently done the way it is.
The text was updated successfully, but these errors were encountered: