Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trt plugin clone and initialize bugs in TRT7.1+ #30709

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

shangzhizhou
Copy link
Member

PR types

Bug fixes

PR changes

Others

Describe

bug fixes:trt要求clone出来的plugin必须是直接可用的,一个类型只会调用一次initialize。所以intialize适合做可以共享的只读变量分配,clone的时候共享指针。本PR修复某些plugin不符合该准则的部分。具体问题也可参考issue #24108#24107

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@shangzhizhou shangzhizhou changed the title fix trt plugin clone and initialize bugs fix trt plugin clone and initialize bugs in TRT7.1+ Jan 27, 2021
Copy link
Contributor

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit b909450 into PaddlePaddle:develop Feb 2, 2021
@shangzhizhou shangzhizhou deleted the trt_plugin branch February 2, 2021 02:08
shangzhizhou added a commit to shangzhizhou/Paddle that referenced this pull request Feb 2, 2021
* fix trt plugin clone and initialize bugs

* fix unit test error

* enable trt in ci py3

* update unittest timeout
Superjomn pushed a commit that referenced this pull request Feb 5, 2021
Co-authored-by: tianshuo78520a <707759223@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants