Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle-TRT] incorrect Plugin usage #24108

Closed
jeng1220 opened this issue Apr 23, 2020 · 3 comments
Closed

[Paddle-TRT] incorrect Plugin usage #24108

jeng1220 opened this issue Apr 23, 2020 · 3 comments
Assignees

Comments

@jeng1220
Copy link
Collaborator

The all data members of cloned plugin must be set in IPluginV2::clone. The plugin only calls IPlugin*::initialize once when creating ICudaEngine. The cloned plugin won't call IPlugin*::initialize after IExecutionContext is created, but TensorRT may clone the plugin during the creation of IExecutionContext and use the cloned plugin to infer the model.

I fix a plugin as example, see #24106. Following plugins have the same bug at least:

  • ElementWisePlugin
  • InstanceNormPlugin
  • PReluPlugin
  • SkipLayerNormPluginDynamic
  • SplitPlugin

Read https://docs.nvidia.com/deeplearning/sdk/tensorrt-developer-guide/index.html#ipluginext to know more.

@jeng1220
Copy link
Collaborator Author

jeng1220 commented Apr 23, 2020

@NHZlX
This is a serious bug. Please assign someone to fix it. Otherwise, all Paddle-TRT applications will crash after you upgrade TensorRT to next version, because new version of TensorRT always uses cloned plugin to infer the model

@NHZlX NHZlX self-assigned this Apr 26, 2020
@NHZlX
Copy link
Contributor

NHZlX commented Apr 26, 2020

这个问题新版本lib拿到后会进行解决。

@paddle-bot-old
Copy link

Since you haven't replied for more than a year, we have closed this issue/pr.
If the problem is not solved or there is a follow-up one, please reopen it at any time and we will continue to follow up.
由于您超过一年未回复,我们将关闭这个issue/pr。
若问题未解决或有后续问题,请随时重新打开,我们会继续跟进。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants