Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: TSv2: Table to handle trains times and margins #7427

Merged
merged 1 commit into from
May 30, 2024
Merged

front: TSv2: Table to handle trains times and margins #7427

merged 1 commit into from
May 30, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented May 16, 2024 •
edited
Loading

close #7024

@Uriel-Sautron Uriel-Sautron changed the title front: TSv2: Time stop componant front: TSv2: Table to handle trains times and margins May 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.75%. Comparing base (9417f7a) to head (c9e43a1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##                dev    #7427       +/-   ##
=============================================
+ Coverage     29.33%   53.75%   +24.41%     
=============================================
  Files          1203       69     -1134     
  Lines        147532     4240   -143292     
  Branches       2897        0     -2897     
=============================================
- Hits          43283     2279    -41004     
+ Misses       102542     1961   -100581     
+ Partials       1707        0     -1707
Flag Coverage Δ
core ?
editoast ?
front ?
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/ts-v2-table-train-time branch 3 times, most recently from 09a755c to 9095ce3 Compare May 26, 2024 11:24
@Uriel-Sautron Uriel-Sautron marked this pull request as ready for review May 28, 2024 12:27
@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner May 28, 2024 12:27
clarani
clarani reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs:

  • if I delete the itinerary, the table timesAndStops is still displayed

front/public/locales/fr/timesStops.json Outdated Show resolved Hide resolved
front/public/locales/en/timesStops.json Outdated Show resolved Hide resolved
front/public/locales/fr/timesStops.json Show resolved Hide resolved
front/public/locales/en/timesStops.json Show resolved Hide resolved
front/public/locales/en/timesStops.json Outdated Show resolved Hide resolved
front/public/locales/fr/timesStops.json Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/views/v2/ManageTrainScheduleV2.tsx Outdated Show resolved Hide resolved
clarani
clarani reviewed May 29, 2024
View reviewed changes
front/src/applications/operationalStudies/views/v2/ManageTrainScheduleV2.tsx Show resolved Hide resolved
front/src/applications/operationalStudies/hooks.ts Show resolved Hide resolved
front/src/modules/pathfinding/components/Itinerary/ItineraryV2.tsx Outdated Show resolved Hide resolved
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx Outdated Show resolved Hide resolved
front/src/modules/pathfinding/utils.ts Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
@Uriel-Sautron Uriel-Sautron force-pushed the usn/ts-v2-table-train-time branch from 9ba0d05 to 83b962a Compare May 29, 2024 18:33
clarani
clarani reviewed May 30, 2024
View reviewed changes
front/src/modules/pathfinding/utils.ts Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/src/modules/timesStops/TimesStops.tsx Outdated Show resolved Hide resolved
front/public/locales/fr/timesStops.json Outdated Show resolved Hide resolved
@Uriel-Sautron Uriel-Sautron force-pushed the usn/ts-v2-table-train-time branch from c91c7d7 to b5568d8 Compare May 30, 2024 12:11
@Uriel-Sautron
front: create component for times and stop train schedule v2
c9e43a1 
- add column name, ch, duration

- add data for add data test for mock api endpoint

- add columns reception on closed signal an theoretical margin

- regex validation margin

- add allVias property to ManageTrainSchedulePathProperties

- modif insertViasInOPs to upsertViasInOPs

- StdcmView: change inserViasInOPs to upserViasInOPs
- update TimeColumnComponent

- create function formatMargin and formatSchedule

- format arrival for schedule

- remove departure in TimesStops
- add toast error if the margin is invalid

- add remove error toast
- add remove vias button

- fix review comments

- fix bug when deleted the itinerary

- fix review comments
@Uriel-Sautron Uriel-Sautron force-pushed the usn/ts-v2-table-train-time branch from b5568d8 to c9e43a1 Compare May 30, 2024 12:21
@clarani clarani added this pull request to the merge queue May 30, 2024
Merged via the queue into dev with commit 4ae7056 May 30, 2024
17 checks passed
@clarani clarani deleted the usn/ts-v2-table-train-time branch May 30, 2024 13:42
@SharglutDev SharglutDev mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: create a table to handle trains times and margins
3 participants
@Uriel-Sautron @codecov-commenter @clarani