Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a via when setting a train itinerary doesn't update its schedules #7517

Closed
SharglutDev opened this issue May 26, 2024 · 2 comments · Fixed by #7634
Closed

Adding a via when setting a train itinerary doesn't update its schedules #7517

SharglutDev opened this issue May 26, 2024 · 2 comments · Fixed by #7634
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented May 26, 2024

What happened?

In a scenario, when adding vias by clicking on map, by the suggested vias modal, or via the rocket, it doesn't update the schedule property of the train. On the example below, the St Malo trains have 2 vias each so it should show at least 2 steps in the details (3 if we count the destination ? Ask a PO for that).

Capture d’écran 2024-05-26 à 22 25 45

What did you expect to happen?

Even if we can't set any duration with this features, it should update the train schedule property by setting the duration property at null in the PathStep store. This will result to a valid information of the steps in the timetable when opening the train details.

How can we reproduce it (as minimally and precisely as possible)?

  1. Go to a scenario
  2. Add a train with at least 1 or 2 vias
  3. Open the train details by clicking on the eye icon at the top and see that it still shows 1 step.

What operating system, browser and environment are you using?

  • Browser: Firefox v126
  • OS: macOS Sonoma 14.5
  • Env: Dev

OSRD version (top right corner Account button > Informations)

dev 4b0f2d6

@SharglutDev SharglutDev added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug labels May 26, 2024
@SharglutDev SharglutDev changed the title Adding a via when setting a train itinerary doesn't update his schedules Adding a via when setting a train itinerary doesn't update its schedules May 26, 2024
@SharglutDev
Copy link
Contributor Author

Might be fixed by #7427

@SarahBellaha SarahBellaha self-assigned this Jun 5, 2024
@axrolld
Copy link
Contributor

axrolld commented Jun 6, 2024

Vias without proper stop shouldn't increase the stop counter, however the counter isn't right with TSV2. If a stop is added, the destination isn't considered as a stop anymore.
Hence :

  • If no stop is specified : 1 stop displayed (the destination)
  • If n stop(s) is/are specified (n >= 1): n stop displayed (destination excluded)

Destination should always be taken into account when counting stops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants