Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add signal projection endpoint for v2 #7304

Merged
merged 5 commits into from
Apr 26, 2024
Merged

core: add signal projection endpoint for v2 #7304

merged 5 commits into from
Apr 26, 2024

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Apr 24, 2024 •
edited
Loading

Fixes #6856.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.07492% with 273 lines in your changes are missing coverage. Please review.

Project coverage is 29.08%. Comparing base (1b0d697) to head (8f3e8ed).

Files Patch % Lines
.../sncf/osrd/signal_projection/SignalProjectionV2.kt 0.00% 180 Missing ⚠️
...i_v2/project_signals/SignalProjectionEndpointV2.kt 0.00% 29 Missing ⚠️
.../api_v2/project_signals/SignalProjectionRequest.kt 0.00% 17 Missing ⚠️
...api_v2/project_signals/SignalProjectionResponse.kt 0.00% 17 Missing ⚠️
editoast/src/views/v2/train_schedule/projection.rs 0.00% 12 Missing ⚠️
...kotlin/fr/sncf/osrd/utils/json/UnitJsonAdapters.kt 25.00% 7 Missing and 2 partials ⚠️
...in/fr/sncf/osrd/sim_infra/api/InterlockingInfra.kt 0.00% 3 Missing ⚠️
...fr/sncf/osrd/sim_infra/api/LoadedSignalingInfra.kt 0.00% 3 Missing ⚠️
...srd/api/api_v2/path_properties/PathPropResponse.kt 83.33% 2 Missing ⚠️
...ava/fr/sncf/osrd/api/SignalProjectionEndpoint.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7304      +/-   ##
============================================
- Coverage     29.10%   29.08%   -0.03%     
- Complexity     2017     2020       +3     
============================================
  Files          1133     1137       +4     
  Lines        139360   139629     +269     
  Branches       2729     2757      +28     
============================================
+ Hits          40559    40608      +49     
- Misses        97196    97412     +216     
- Partials       1605     1609       +4
Flag Coverage Δ
core 76.76% <10.92%> (-1.17%) ⬇️
editoast 72.03% <0.00%> (-0.05%) ⬇️
front 9.33% <100.00%> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/ts2-signal_projection branch from cd14115 to d600df1 Compare April 24, 2024 02:23
@Erashin Erashin linked an issue Apr 24, 2024 that may be closed by this pull request
TS2: Add core signal projection endpoint #6856
Closed
2 tasks
@Erashin Erashin force-pushed the ech/ts2-simulation branch from 0a00c9c to ca4cfbc Compare April 24, 2024 09:30
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch 2 times, most recently from 49b301e to a14c14b Compare April 24, 2024 10:03
@flomonster flomonster force-pushed the ech/ts2-simulation branch 3 times, most recently from fadf2d5 to c911ea5 Compare April 24, 2024 22:17
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch 2 times, most recently from 9bb8ded to e1165f3 Compare April 25, 2024 07:57
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch 3 times, most recently from 54207e5 to e210c3d Compare April 25, 2024 09:07
@flomonster flomonster force-pushed the alch/ts2-signal_projection branch from e210c3d to 8ac4a8e Compare April 25, 2024 09:11
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch from 15e179c to bcfdb8b Compare April 25, 2024 09:18
@Erashin Erashin marked this pull request as ready for review April 25, 2024 10:17
@Erashin Erashin requested a review from a team as a code owner April 25, 2024 10:17
@Erashin Erashin requested review from multun and eckter and removed request for multun April 25, 2024 10:17
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch 3 times, most recently from 02dddec to f16f390 Compare April 25, 2024 12:23
eckter
eckter approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some weird stuff that was already weird in the v1, other than that lgtm

core/src/main/kotlin/fr/sncf/osrd/signal_projection/SignalProjectionV2.kt Outdated Show resolved Hide resolved
core/src/main/kotlin/fr/sncf/osrd/signal_projection/SignalProjectionV2.kt Outdated Show resolved Hide resolved
@Erashin Erashin requested a review from a team as a code owner April 25, 2024 16:08
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch from fa94289 to 1052ae8 Compare April 26, 2024 07:10
@Erashin Erashin removed the request for review from a team April 26, 2024 07:19
@Erashin Erashin force-pushed the alch/ts2-signal_projection branch 3 times, most recently from 923d2d8 to 5351795 Compare April 26, 2024 09:46
@flomonster flomonster force-pushed the alch/ts2-signal_projection branch from 5351795 to 38c6103 Compare April 26, 2024 13:15
@flomonster flomonster force-pushed the alch/ts2-signal_projection branch from 4140eab to 73db534 Compare April 26, 2024 14:10
Base automatically changed from ech/ts2-simulation to dev April 26, 2024 14:38
@flomonster flomonster force-pushed the alch/ts2-signal_projection branch from 73db534 to 8f3e8ed Compare April 26, 2024 14:40
@flomonster flomonster requested a review from a team April 26, 2024 14:43
Tguisnet
Tguisnet approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the editoast part

editoast/src/views/v2/train_schedule/projection.rs Show resolved Hide resolved
@flomonster flomonster enabled auto-merge April 26, 2024 15:39
@flomonster flomonster added this pull request to the merge queue Apr 26, 2024
Merged via the queue into dev with commit c77c9f9 Apr 26, 2024
17 checks passed
@flomonster flomonster deleted the alch/ts2-signal_projection branch April 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tguisnet Tguisnet Tguisnet approved these changes

@flomonster flomonster flomonster left review comments

@leovalais leovalais leovalais approved these changes

@eckter eckter eckter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS2: Add core signal projection endpoint
6 participants
@Erashin @codecov-commenter @eckter @flomonster @leovalais @Tguisnet