Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: refacto stdcm op schedule #10192

Merged
merged 6 commits into from
Jan 9, 2025
Merged

front: refacto stdcm op schedule #10192

merged 6 commits into from
Jan 9, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 24, 2024

closes #10190

See commits

@clarani clarani requested a review from a team as a code owner December 24, 2024 13:19
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.34188% with 23 lines in your changes missing coverage. Please review.

Project coverage is 81.53%. Comparing base (c806a2f) to head (dc8f701).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 23 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10192      +/-   ##
==========================================
- Coverage   81.58%   81.53%   -0.05%     
==========================================
  Files        1062     1062              
  Lines      104970   104874      -96     
  Branches      722      722              
==========================================
- Hits        85636    85509     -127     
- Misses      19293    19324      +31     
  Partials       41       41
Flag Coverage Δ
editoast 73.65% <ø> (-0.05%) ⬇️
front 89.26% <80.34%> (-0.05%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch 2 times, most recently from 2c31a7d to b5f5574 Compare December 24, 2024 14:04
@clarani clarani requested a review from a team as a code owner December 24, 2024 15:08
Uriel-Sautron
Uriel-Sautron reviewed Dec 24, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I have nothing to say about the code. I'm still testing the application's behavior.
Thanks for the refacto.

@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch from daac10b to b5f5574 Compare December 30, 2024 08:51
@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch 2 times, most recently from b8af3cb to 3a36df3 Compare January 7, 2025 13:30
SharglutDev
SharglutDev reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great refacto !

front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx Outdated Show resolved Hide resolved
front/src/reducers/osrdconf/stdcmConf/index.ts Outdated Show resolved Hide resolved
front/src/reducers/osrdconf/stdcmConf/index.ts Outdated Show resolved Hide resolved
front/src/reducers/osrdconf/stdcmConf/index.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx Show resolved Hide resolved
front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx Show resolved Hide resolved
front/tests/utils/setup-utils.ts Outdated Show resolved Hide resolved
@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch from 3a36df3 to ccd7409 Compare January 7, 2025 17:08
@SharglutDev SharglutDev mentioned this pull request Jan 7, 2025
Merged
This was referenced Jan 8, 2025
Open
Closed
@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch 2 times, most recently from b6412be to 4481c3a Compare January 8, 2025 11:09
SharglutDev
SharglutDev approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@clarani clarani enabled auto-merge January 8, 2025 12:33
@SharglutDev SharglutDev mentioned this pull request Jan 8, 2025
Merged
@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch 4 times, most recently from d4ad536 to bec74cc Compare January 9, 2025 08:41
@clarani
front: move main actions from parent component in StdcmOpSchedule
c48617f 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
clarani added 5 commits January 9, 2025 11:37
@clarani
front: compute tolerances directly in StdcmOpSchedule
0ff8221 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: remove opScheduleTimeType props from StdcmOpScheduleProps
8587a2d 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: update stdcm arrival dates when searchDatetimeWindow changes
f3e623f 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: remove opTimingData from StdcmOpSchedule and simplify date man…
2075358 
…agement

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: add PickAndNonNullableFields type
dc8f701 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/10190-refacto-stdcm-op-schedule branch from bec74cc to dc8f701 Compare January 9, 2025 10:37
Maymanaf
Maymanaf approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work !
LGTM for e2e-tests

@clarani clarani added this pull request to the merge queue Jan 9, 2025
Merged via the queue into dev with commit 2e83f60 Jan 9, 2025
27 checks passed
@clarani clarani deleted the cni/10190-refacto-stdcm-op-schedule branch January 9, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron left review comments

@SharglutDev SharglutDev SharglutDev approved these changes

@Maymanaf Maymanaf Maymanaf approved these changes

@kmer2016 kmer2016 Awaiting requested review from kmer2016

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdcm: refacto stdcm op schedule
5 participants
@clarani @codecov-commenter @Maymanaf @Uriel-Sautron @SharglutDev