Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid op time stdcm #10277

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix invalid op time stdcm #10277

merged 1 commit into from
Jan 9, 2025

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jan 7, 2025 •
edited
Loading

fix #10267

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (0e377b3) to head (ad4a881).
Report is 27 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10277      +/-   ##
==========================================
+ Coverage   81.53%   81.55%   +0.02%     
==========================================
  Files        1059     1062       +3     
  Lines      104508   104953     +445     
  Branches      722      722              
==========================================
+ Hits        85213    85598     +385     
- Misses      19254    19314      +60     
  Partials       41       41
Flag Coverage Δ
editoast 73.62% <ø> (-0.12%) ⬇️
front 89.30% <100.00%> (+0.05%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev
front: fix stdcm simulation loader popping if time is invalid
ad4a881 
The simulation now becomes pending only if all fields are valid.

Signed-off-by: SharglutDev <p.filimon75@gmail.com>
@SharglutDev SharglutDev force-pushed the pfn/front/fix-invalid-op-time-stdcm branch from 6555312 to ad4a881 Compare January 9, 2025 10:30
@SharglutDev SharglutDev marked this pull request as ready for review January 9, 2025 10:31
@SharglutDev SharglutDev requested a review from a team as a code owner January 9, 2025 10:31
@SharglutDev SharglutDev enabled auto-merge January 9, 2025 10:32
clarani
clarani approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

kmer2016
kmer2016 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Nice catch

@SharglutDev SharglutDev added this pull request to the merge queue Jan 9, 2025
Merged via the queue into dev with commit dd492f0 Jan 9, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-invalid-op-time-stdcm branch January 9, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@kmer2016 kmer2016 kmer2016 approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simulation loader pops even if time range is wrong
4 participants
@SharglutDev @codecov-commenter @kmer2016 @clarani