Skip to content

Submission 1

Compare
Choose a tag to compare
@Nicklas373 Nicklas373 released this 04 Jan 03:44
Treewide: Apply dicoding advice on submission 1

* DetailShowActivity.kt
  - Re-order "companion object" code position below other code (as kotlin class layout suggestion)
  - Use "apply" for binding to avoid re-write binding every want to connect some textview or etc
  - Use constant value for genre and include into companion object

* MovieEntity.kt & All Entity
  - Use val instead of var when variable aren't supposed to change in other time

* MovieFragment.kt & TvShowFragment.kt
  - Avoid use lateinit for binding

While i'm applying several advice from reviewer, there's still some of it that i can't apply it now. Maybe later, and also this is closing for submission 1