Releases: Nicklas373/DicodingBAJP
Releases · Nicklas373/DicodingBAJP
Patch #1 for submission 3
Submission_3.1 Update README.md
Submission 3
Gradle: Apply dicoding advice on submission 3 * Update mockito library version from 3.6.0 to 4.2.0 There's actually more of this for advice from dicoding reviewer, i'll apply that later. For now i'm not really understand how to apply, since both of my adapter have different data. Also this is moved to submission 3 branch and after this, documentation.
v1.5-pre-submission-3
Treewide: Implement Instrumentation and Unit test for Raw Query Preparing for submission 3
Submission 2
Treewide: Apply dicoding advice on submission 2 * ApiConfig Only use logging interceptor while in debug build * Adapter (Api or Local) Change variable to "_" when it's not use on adapter use declaration of "with(binding)" to avoid loop written of binding * Repository Re-order companion object into bottom line of the code * SplashScreen Re-declare constant value for timer on companion object Also include cleanup code ....
v1.5-init
Treewide: Refactoring Repository - Drop fetch data from Dummy on repository - Drop all JSON assets data - Drop genre & cast data on layout that was fetched from dummy - Drop dependencies on Injection class from JsonHelper after getting refactoring to Helper - Include Production Companies on layout & fetch genre only from API - Move API Key to BuildConfig on gradle properties - Re-implement MutableLiveData for repository - Refactoring repository for only fetch data from API - Refactoring all JSON tree response from Dummy to only using API JSON tree response (Include changes to all activity, viewmodel and adapter) - Reconfigure Datasource after refactoring repository tree - Reconfigure all adapter after refactoring JSON tree response - Re-write JSON Helper -> Helper class which are not tighten to JSON reading scenario from assets folder anymore, since now helper directly append data from repository - Other misc changes (Including code cleanup) ...
v1.2-init
gradle: Bump to v1.3 Also release checkpoint apk
Submission 1
Treewide: Apply dicoding advice on submission 1 * DetailShowActivity.kt - Re-order "companion object" code position below other code (as kotlin class layout suggestion) - Use "apply" for binding to avoid re-write binding every want to connect some textview or etc - Use constant value for genre and include into companion object * MovieEntity.kt & All Entity - Use val instead of var when variable aren't supposed to change in other time * MovieFragment.kt & TvShowFragment.kt - Avoid use lateinit for binding While i'm applying several advice from reviewer, there's still some of it that i can't apply it now. Maybe later, and also this is closing for submission 1
v1.1-init
gradle: Cleanup and upgrading
Iniitial Release
Treewide: Include TvShow Details and Cast List * Merge into 1 layout for cast list but still use 2 adapter where it's split by ID * Formatted all lines * Other dummy changes