-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced ActionableMessage in confirm-page-container-content #20417
Replaced ActionableMessage in confirm-page-container-content #20417
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1fece3a
to
2f60fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pritam1813, thanks for your contribution. I noticed your "after" screenshots may have been out of date. I've made some small updates and updated the description images. LGTM
Codecov Report
@@ Coverage Diff @@
## develop #20417 +/- ##
===========================================
- Coverage 68.69% 68.69% -0.00%
===========================================
Files 991 991
Lines 38281 38282 +1
Branches 10253 10254 +1
===========================================
- Hits 26296 26295 -1
- Misses 11985 11987 +2
|
Explanation
ActionableMessage
withBannerAlert
inui/components/app/confirm-page-container/confirm-page-container-content/confirm-page-container-content.component.js
<Typography />
with<Text />
components inside theBannerAlert
component.<Button />
component(ui/components/component-library)
with new<Button />
component(ui/components/component-library/button/button.js)
inside theBannerAlert
component.Screenshots/Screencaps
Before
After
Not sure how to display the first warning but it would look like this. Commented out code to display
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.