Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ActionableMessage in confirm-page-container-content #20417

Conversation

pritam1813
Copy link
Contributor

@pritam1813 pritam1813 commented Aug 6, 2023

Explanation

Screenshots/Screencaps

Before

Before

After

Screenshot 2023-08-14 at 6 09 01 PM

Not sure how to display the first warning but it would look like this. Commented out code to display

Screenshot 2023-08-14 at 6 27 22 PM

Manual Testing Steps

  • Create New Build from this PR
  • Install and Setup account
  • Click Send then Input address
  • In Amount section enter any Insufficient Amount and then next.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@pritam1813 pritam1813 requested a review from a team as a code owner August 6, 2023 14:33
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Aug 10, 2023
@georgewrmarshall georgewrmarshall force-pushed the part-of-#19528-in-confirm-page-container-content branch from 1fece3a to 2f60fdf Compare August 15, 2023 01:19
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pritam1813, thanks for your contribution. I noticed your "after" screenshots may have been out of date. I've made some small updates and updated the description images. LGTM

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #20417 (c8a310f) into develop (63d67f3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #20417      +/-   ##
===========================================
- Coverage    68.69%   68.69%   -0.00%     
===========================================
  Files          991      991              
  Lines        38281    38282       +1     
  Branches     10253    10254       +1     
===========================================
- Hits         26296    26295       -1     
- Misses       11985    11987       +2     
Files Changed Coverage Δ
...ontent/confirm-page-container-content.component.js 92.00% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

@garrettbear garrettbear merged commit 6512cac into MetaMask:develop Aug 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants