replaced actionablemessage in Import-Token.js #20147
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Hi @georgewrmarshall , please review this. |
Codecov Report
@@ Coverage Diff @@
## develop #20147 +/- ##
===========================================
- Coverage 69.45% 69.45% -0.01%
===========================================
Files 984 984
Lines 37290 37290
Branches 10012 10012
===========================================
- Hits 25899 25897 -2
- Misses 11391 11393 +2
|
There was a problem hiding this comment.
Hey @pritam1813, This is looking great! I have one suggestion and one optional suggestion
| import Button from '../../../components/ui/button'; | ||
| import Box from '../../../components/ui/box'; |
There was a problem hiding this comment.
Optional: If you'd like to take this PR a step further you could use the Box and Button components from the component-library as well. You will have to update some of the component props as the component API is different for the Button component so it does add a level of complexity to completing this task. Completely optional!
There was a problem hiding this comment.
You could also replace UrlIcon with AvatarToken from the component-library
There was a problem hiding this comment.
Yeah sure, why not.This was only a single line change PR anyway. Should I try and remove all the deprecated Components in this file ?
There was a problem hiding this comment.
I think that would still make this PR a reasonable size to review. You could also do it in parts if you'd like to get this PR in first. Then create another PR to update the rest.
There was a problem hiding this comment.
I should point out that the more components that are replaced the more likely hood you will need to update e2e tests which adds a fair amount of complexity to the task.
georgewrmarshall
added
the
team-design-system
…taMask#20148) * adds listeners for signatureControll and adds the handleSigningEvents method * clean up * updates signature request containers files * adds necessary methods * wip * signing flow with core methods * yarn lint * updates logic to fit latest signatureCOntroller * updates mmi extension package * updates signature-controller and message-manager packages * checkout develop lock file and run yarn * checkout develop lock file and package.json to test circleci * test fix * adds signature-controller new version * updates mmi extension package * tx-list update and runs lavamoat auto * lint fix * runs lavamoat auto * resets lavamoat/build-system/policy.jsono to develop * Update LavaMoat policies * adds back the dispatch * lint * changes needed to generate a mmi build * adds metametricsId in url param * adds necessary fence --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Explanation
ui/pages/swaps/import-token/import-token.jsScreenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.