-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework install_parameters generation #472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 59.44% 59.44%
=======================================
Files 12 12
Lines 1684 1684
=======================================
Hits 1001 1001
Misses 683 683
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xchapron-ledger
force-pushed
the
xch/app-metadata
branch
3 times, most recently
from
November 27, 2023 15:31
9f0764d
to
0d391f7
Compare
xchapron-ledger
force-pushed
the
xch/app-metadata
branch
2 times, most recently
from
November 28, 2023 08:59
4c4a139
to
0209701
Compare
xchapron-ledger
force-pushed
the
xch/app-metadata
branch
from
November 28, 2023 15:28
0209701
to
ae6ef59
Compare
xchapron-ledger
pushed a commit
to LedgerHQ/app-cardano
that referenced
this pull request
Nov 30, 2023
This will become necessary once LedgerHQ/ledger-secure-sdk#472 is merged and cherry-picked.
Update metadata to keep the exact same values
xchapron-ledger
force-pushed
the
xch/app-metadata
branch
from
December 1, 2023 10:37
ae6ef59
to
117f71b
Compare
sgliner-ledger
approved these changes
Dec 1, 2023
xchapron-ledger
force-pushed
the
xch/app-metadata
branch
from
December 1, 2023 17:18
117f71b
to
66934c4
Compare
This includes: - Generation before build time and inclusion in the binary at build time whereas it was previously done only during sideloading. This allows: * to have a proper app size when using arm-none-eabi-size bin/app.elf, taking into account the size of the install_parameters * to have complete artifacts app.elf, app.hex, app.map, app.asm which can be used for debug * to have a proper Speculos emulation on install_parameters interactions. - Parsing of APP_LOAD_PARAMS variable so that its differents fields can be used cleanly - New symbols in the linker script to expose the start and the end of install_parameters, allowing to retrieve its size. - A small change in src/pic.c to avoid application sha256 change in this commit. The change will be removed in the next commit. This commit as been tested without modification on the application sha256 (which includes install_parameters generated at build time or as previously by ledgerblue.loadapp script) on numerous applications.
Following previous commit, this now included the install_parameters that are added during the build process.
xchapron-ledger
force-pushed
the
xch/app-metadata
branch
from
December 1, 2023 17:28
66934c4
to
db83c5c
Compare
This was referenced Dec 4, 2023
xchapron-ledger
pushed a commit
to LedgerHQ/app-cardano
that referenced
this pull request
Dec 4, 2023
This will become necessary once LedgerHQ/ledger-secure-sdk#472 is merged and cherry-picked. (cherry picked from commit 973b595)
6 tasks
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include
Tests:
Tested on a list of 25 apps (but no specific app sha1) with no app.sha256 change:
Tasks:
APP_LOAD_PARAMS
should be defined beforeinclude $(BOLOS_SDK)/Makefile.rules
=> update app Makefile app load params fix app-cardano#65#if TARGET_NAME == TARGET_NANOS
used => update app to drop them (src: Drop unused code app-plugin-rarible#10)