Cherry pick for API_LEVEL_14 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a6e057f)
(cherry picked from commit b00bc92)
(cherry picked from commit 3346f4d)
On devices where the SE drives the screen, there is no need for seph exchanges to control the screen. The previous version was assuming UX_DISPLAY_NEXT_ELEMENT() was changing the state of the MCU <-> SE exchanges, which is false, this was leading to a deadlock on Speculos. (cherry picked from commit 1b75b43)
(cherry picked from commit c5e41db)
…le text (cherry picked from commit b218dce)
(cherry picked from commit 1a42176)
Update metadata to keep the exact same values (cherry picked from commit 536c84d)
This includes:
- Generation before build time and inclusion in the binary at build time
whereas it was previously done only during sideloading.
This allows:
* to have a proper app size when using arm-none-eabi-size bin/app.elf,
taking into account the size of the install_parameters
* to have complete artifacts app.elf, app.hex, app.map, app.asm which
can be used for debug
* to have a proper Speculos emulation on install_parameters
interactions.
- Parsing of APP_LOAD_PARAMS variable so that its differents fields can
be used cleanly
- New symbols in the linker script to expose the start and the end of
install_parameters, allowing to retrieve its size.
- A small change in src/pic.c to avoid application sha256 change in this
commit. The change will be removed in the next commit.
This commit as been tested without modification on the application
sha256 (which includes install_parameters generated at build time or as
previously by ledgerblue.loadapp script) on numerous applications.
(cherry picked from commit 34448c2)
Following previous commit, this now included the install_parameters that are added during the build process. (cherry picked from commit 2a823e5)
(cherry picked from commit db83c5c)
(cherry picked from commit 9ae87d9)
(cherry picked from commit a4cb18b)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## API_LEVEL_14 #484 +/- ##
===============================================
Coverage ? 59.44%
===============================================
Files ? 12
Lines ? 1684
Branches ? 0
===============================================
Hits ? 1001
Misses ? 683
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tdejoigny-ledger
approved these changes
Dec 6, 2023
fbeutin-ledger
approved these changes
Dec 6, 2023
(cherry picked from commit 40d6a68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picks from:
Changes include