Fixes #463 #579
Fixes #463 #579
Conversation
|
Someone is attempting to deploy a commit to the Klimatbyrån Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This changes how the page looks. I'm not sure it's "unneeded" then (quoting #463). @Greenheart given that we're moving to a new typeface for klimatkollen, please weigh on which font is the one to be used going forward. |
|
Thanks for taking a look at this Narges! I gave unclear instructions in #463, and like Ludvig mentioned I should have defined what I meant with "unneeded Borna font assets". Going forward, I will try to add more context to issues to define the goals with each update we want to make. And please let me know if anything needs to be clarified :) For #463, what I had in mind was to remove the testing files (primarily the html files) from I'm updating the all fonts and colors as part of #590, but until then we should keep the website look intact. Thus, I will make changes to this PR so it's ready to merge, and then continue in my other branch with updating the font and colors. Finally, a side note:@LudwikJaniuk Perhaps we should also look into creating an GitHub issue template, to automatically get a good structure when we create issues. Here's some inspiration: /~https://github.com/29ki/29k/tree/main/.github/ISSUE_TEMPLATE Most importantly, we need a clear definition of "done" for each issue, to make it easier to understand the evaluation criteria to get a PR merged. |
|
Agreed on the side note. I'll look into it. |
* updated test of smhi data focusing on the right columns being in the datafile (#580) * add all numeric columns to historical emissions (#573) * delete old data output files and remove consumption data to excel (#575) * Feat/make emission calculations tests non-dependent on last year with SMHI data (#586) * update last year w smhi data and cement deduction values for 2022 * update smhi test files * make tests work regardless of last year with smhi data * change from year 2022 to 2021 (to be introduced in later pr) * add 2022 to smhi test * Feature/improved table ux (#567) * Allow closing the main menu by pressing the Escape key * Replace devices.mobile (which used max-width) with other breakpoints. This makes sure all breakpoints are consistent and all media queries should be written with a mobile-first approach. * Ensure hamburger menu has consistent size and positioning for all screen sizes * Change breakpoint size to standard value, since it was only used in one place * Ensure consistent height for the Header. Also improve vertical alignment for logo. Also make desktop navigation appear already for smaller laptop screens, to make give a better UX. * Improve spacing for the RegionalView * WIP: Make the CompanyView use the page scroll * Fix CompanyView table header positioning * Use full page scroll for RegionalView table * Update copy to match new version * Alternative 1 for CompanyView table * Alternative 2 for CompanyView table * Add sticky footer for RegionalView too * Fix map height for RegionalView * Remove unused calc() * Attempt to simplify CSS calculations to hopefully fix iOS positioning problems * Simplify copy to save space * WIP: experiment with IntersectionObserver to work around position sticky not working for `thead` elements in Safari * Override tough-cookie dependency to remove Node.js deprecation warning in Node >= 21 * Mock IntersectionObserver to fix tests for CompanyView and RegionalView * Try if inset-block-start works better for sticky thead * FINALLY! Fixex position sticky in Safari 17. This already worked in older versions of Safari and all other browsers, but for some reason Safari 17 seems to have a buggy implementation. * Cleanup WIP code and comments * Cleanup tests and import * Add webkit prefix for increased backwards compatibility * Fixes #463 (#579) * removed the unneeded Borna font assets(#463) * Keep Borna font files used for the site, and remove other files * Remove unintended changes --------- Co-authored-by: Narges <nasadnajafi@righthub.com> Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * fix words written twice (#595) * fix words written twice * Update source data file too --------- Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * show map view first (#597) * Social links update (#578) * Social links update Added links with corresponding icons to Klimatkollen's profile on Facebook and Instagram. * Discord logo Fixed dimensions * Update FooterSocialLinks.tsx * Added only Instagram icon and link * Update company data (#601) * Add an issue template for better issues. (#598) Add an issue template for better issues. * Fix test after changing the default view for RegionalView (#602) * Fix: #528 Make map legend floating and add background color. (#532) * experiment with map labels * feat: floating titlecontainer with background * fix: hide map pegend when in list view * chore: formatting * Update styles * Allow scrolling even when the MapLabels are on top to improve navigation on mobile This sometimes makes the map labels show beneath, but overall this is an UX improvement for mobile users which makes it worth it. --------- Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * reverse climate data to earlier version (#604) * Increase table footer font size on larger screens (#605) * Render ToggleButton with styled-components-wrapper to fix tests (#606) --------- Co-authored-by: Mathias Bergqvist <mthbqv@gmail.com> Co-authored-by: Elvira <elvbom@users.noreply.github.com> Co-authored-by: N-Asadnajafi <51734450+N-Asadnajafi@users.noreply.github.com> Co-authored-by: Narges <nasadnajafi@righthub.com> Co-authored-by: Larissa Lang <126619240+lalarus@users.noreply.github.com> Co-authored-by: Lasse2500 <70321631+Lasse2500@users.noreply.github.com> Co-authored-by: Ludvig Janiuk <ludvig.janiuk@gmail.com> Co-authored-by: SimonAM <simonarnemattsson@gmail.com>
Removed the unneeded Borna font assets from the public directory. Please see the differences in the main product and in my local in this picture:
