add all numeric columns to historical emissions #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Greenheart
approved these changes
May 20, 2024
Greenheart
suggested changes
May 20, 2024
There was a problem hiding this comment.
Actually, wait a minute. Something changed in my climate-data.json output.
I get a NaN value in the output, which is not valid JSON.
Investigating what happened.
Details:
Kumla kommun gets "neededEmissionChangePercent": NaN. This feels familiar, maybe you solved this last week in another branch @elvbom?
Greenheart
approved these changes
May 20, 2024
There was a problem hiding this comment.
Now approving this after clarifying with Elvira that the data changes are expected since this version of the data processing assumes the latest SMHI data version (which was 2021 when this PR was submitted and 2022 was just published before I tested this).
This will be updated in upcoming PRs.
Yes, this is because of SMHI emissions data being updated with entries for 2022. It's adressed in #583 |
Greenheart
added a commit
that referenced
this pull request
May 29, 2024
* updated test of smhi data focusing on the right columns being in the datafile (#580) * add all numeric columns to historical emissions (#573) * delete old data output files and remove consumption data to excel (#575) * Feat/make emission calculations tests non-dependent on last year with SMHI data (#586) * update last year w smhi data and cement deduction values for 2022 * update smhi test files * make tests work regardless of last year with smhi data * change from year 2022 to 2021 (to be introduced in later pr) * add 2022 to smhi test * Feature/improved table ux (#567) * Allow closing the main menu by pressing the Escape key * Replace devices.mobile (which used max-width) with other breakpoints. This makes sure all breakpoints are consistent and all media queries should be written with a mobile-first approach. * Ensure hamburger menu has consistent size and positioning for all screen sizes * Change breakpoint size to standard value, since it was only used in one place * Ensure consistent height for the Header. Also improve vertical alignment for logo. Also make desktop navigation appear already for smaller laptop screens, to make give a better UX. * Improve spacing for the RegionalView * WIP: Make the CompanyView use the page scroll * Fix CompanyView table header positioning * Use full page scroll for RegionalView table * Update copy to match new version * Alternative 1 for CompanyView table * Alternative 2 for CompanyView table * Add sticky footer for RegionalView too * Fix map height for RegionalView * Remove unused calc() * Attempt to simplify CSS calculations to hopefully fix iOS positioning problems * Simplify copy to save space * WIP: experiment with IntersectionObserver to work around position sticky not working for `thead` elements in Safari * Override tough-cookie dependency to remove Node.js deprecation warning in Node >= 21 * Mock IntersectionObserver to fix tests for CompanyView and RegionalView * Try if inset-block-start works better for sticky thead * FINALLY! Fixex position sticky in Safari 17. This already worked in older versions of Safari and all other browsers, but for some reason Safari 17 seems to have a buggy implementation. * Cleanup WIP code and comments * Cleanup tests and import * Add webkit prefix for increased backwards compatibility * Fixes #463 (#579) * removed the unneeded Borna font assets(#463) * Keep Borna font files used for the site, and remove other files * Remove unintended changes --------- Co-authored-by: Narges <nasadnajafi@righthub.com> Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * fix words written twice (#595) * fix words written twice * Update source data file too --------- Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * show map view first (#597) * Social links update (#578) * Social links update Added links with corresponding icons to Klimatkollen's profile on Facebook and Instagram. * Discord logo Fixed dimensions * Update FooterSocialLinks.tsx * Added only Instagram icon and link * Update company data (#601) * Add an issue template for better issues. (#598) Add an issue template for better issues. * Fix test after changing the default view for RegionalView (#602) * Fix: #528 Make map legend floating and add background color. (#532) * experiment with map labels * feat: floating titlecontainer with background * fix: hide map pegend when in list view * chore: formatting * Update styles * Allow scrolling even when the MapLabels are on top to improve navigation on mobile This sometimes makes the map labels show beneath, but overall this is an UX improvement for mobile users which makes it worth it. --------- Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * reverse climate data to earlier version (#604) * Increase table footer font size on larger screens (#605) * Render ToggleButton with styled-components-wrapper to fix tests (#606) --------- Co-authored-by: Mathias Bergqvist <mthbqv@gmail.com> Co-authored-by: Elvira <elvbom@users.noreply.github.com> Co-authored-by: N-Asadnajafi <51734450+N-Asadnajafi@users.noreply.github.com> Co-authored-by: Narges <nasadnajafi@righthub.com> Co-authored-by: Larissa Lang <126619240+lalarus@users.noreply.github.com> Co-authored-by: Lasse2500 <70321631+Lasse2500@users.noreply.github.com> Co-authored-by: Ludvig Janiuk <ludvig.janiuk@gmail.com> Co-authored-by: SimonAM <simonarnemattsson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all numeric columns to historical emissions in climate data calculations so that this doesn't need to be hardcoded with future updates from SMHI.