Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/codespaces quickstart #457

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

danuw
Copy link
Collaborator

@danuw danuw commented Jan 31, 2024

Pull Request

Issue Number: Link to Github Issue or Azure Dev Ops Task/Story

Summary

Updates to the devcontainer.json definition to ensure certain extensions are installed by default when the container starts

Changes

I updated the devcontainer definition to ensure certain extensions are installed by default such as:

  • "ms-vscode.vscode-node-azure-pack",
  • "GitHub.copilot",
  • "GitHub.vscode-github-actions",
  • "GitHub.copilot-chat",
  • "ms-dotnettools.vscode-dotnet-runtime",
  • "ms-dotnettools.csdevkit",
  • "ms-dotnetools.csharp"

When we get dotnet 8 update, I plan on further updating the dev container based on github template at /~https://github.com/github/dotnet-codespaces/blob/main/.devcontainer/devcontainer.json

I tested the changes by updating the devcontainer.json and doing a full rebuild of the dev container so everything would be reset to the devcontainer definition.

This shows the workspace after full rebuild with extensions available. Some of extensions shown on the left sidebar were not there before the full rebuild.
workspace after full rebuild with extensions available

FYI Command used to rebuild the full container
Command used to rebuild the full container

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #207

@danuw danuw added documentation Improvements or additions to documentation vNext devops Identify issues that impact delivery lifecycle as opposed to functionality (~basically code changes) labels Jan 31, 2024
@danuw danuw self-assigned this Jan 31, 2024
@danuw danuw requested a review from vaughanknight as a code owner January 31, 2024 08:12
I, Dan Benitah <bdanuw@gmail.com>, hereby add my Signed-off-by to this commit: 44578f4
I, Dan Benitah <bdanuw@gmail.com>, hereby add my Signed-off-by to this commit: 3ae9a00

Signed-off-by: Dan Benitah <bdanuw@gmail.com>
@danuw danuw added the Ready for Review PR Ready for review with the GSF team for merge label Jan 31, 2024
@vaughanknight vaughanknight merged commit ba4121b into dev Feb 7, 2024
8 checks passed
@vaughanknight
Copy link
Contributor

This looks great, thanks Dan!

@danuw danuw added 1.3 Tracking the work towards release 1.3 and removed vNext labels Feb 7, 2024
@vaughanknight vaughanknight deleted the features/codespaces-quickstart branch February 7, 2024 08:04
@danuw danuw removed the Ready for Review PR Ready for review with the GSF team for merge label Feb 12, 2024
@danuw danuw mentioned this pull request Feb 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3 Tracking the work towards release 1.3 devops Identify issues that impact delivery lifecycle as opposed to functionality (~basically code changes) documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Contribution]: Enable codespaces for the SDK repo
2 participants