Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove first-meaningful-paint metric #16047

Merged
merged 12 commits into from
Jun 7, 2024
Merged

core: remove first-meaningful-paint metric #16047

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dd01b17
core(lantern): use LCP instead of FMP for TTI simulation bounds
connorjclark Jun 6, 2024
43ed9e5
fix tests
connorjclark Jun 6, 2024
72d6820
fix stale comments
connorjclark Jun 6, 2024
68638c6
fix stale comments
connorjclark Jun 6, 2024
479e29b
wip
connorjclark Jun 6, 2024
ef7649e
update sample json
connorjclark Jun 6, 2024
76d09ea
fix failing tests
connorjclark Jun 6, 2024
16f9ef7
shell
connorjclark Jun 6, 2024
d62baee
rm fmp from lantern db test
connorjclark Jun 6, 2024
f646f83
Merge remote-tracking branch 'origin/main' into rm-fmp
connorjclark Jun 6, 2024
d899f1a
undo other test changes
connorjclark Jun 7, 2024
834442c
restore strings
connorjclark Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix stale comments
  • Loading branch information
@connorjclark
connorjclark committed Jun 6, 2024
commit 68638c6519508dbcff69666fe78e78a7739d81d9
2 changes: 1 addition & 1 deletion core/test/computed/metrics/interactive-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe('Metrics: TTI', () => {
);

const cpu = [
// quiet period before FMP
// quiet period before FCP
{start: 9000, end: 9900},
{start: 11000, end: 13000},
// quiet period during network activity
Expand Down
Loading