wip

cli/test/smokehouse/test-definitions/perf-preload.js

@@ -52,9 +52,6 @@ const expectations = {
       'speed-index': {
         score: '>=0.80', // primarily just making sure it didn't fail/go crazy, specific value isn't that important
       },
-      'first-meaningful-paint': {
-        score: '>=0.90', // primarily just making sure it didn't fail/go crazy, specific value isn't that important
-      },
       'interactive': {
         score: '>=0.90', // primarily just making sure it didn't fail/go crazy, specific value isn't that important
       },

core/audits/predictive-perf.js

@@ -7,7 +7,6 @@
 import {Audit} from './audit.js';
 import * as i18n from '../lib/i18n/i18n.js';
 import {LanternFirstContentfulPaint} from '../computed/metrics/lantern-first-contentful-paint.js';
-import {LanternFirstMeaningfulPaint} from '../computed/metrics/lantern-first-meaningful-paint.js';
 import {LanternInteractive} from '../computed/metrics/lantern-interactive.js';
 import {LanternSpeedIndex} from '../computed/metrics/lantern-speed-index.js';
 import {LanternLargestContentfulPaint} from '../computed/metrics/lantern-largest-contentful-paint.js';
@@ -52,7 +51,6 @@ class PredictivePerf extends Audit {
     const settings = JSON.parse(JSON.stringify(defaultSettings)); // Use default settings.
     const computationData = {trace, devtoolsLog, gatherContext, settings, URL};
     const fcp = await LanternFirstContentfulPaint.request(computationData, context);
-    const fmp = await LanternFirstMeaningfulPaint.request(computationData, context);
     const tti = await LanternInteractive.request(computationData, context);
     const si = await LanternSpeedIndex.request(computationData, context);
     const lcp = await LanternLargestContentfulPaint.request(computationData, context);
@@ -64,10 +62,6 @@ class PredictivePerf extends Audit {
       optimisticFCP: fcp.optimisticEstimate.timeInMs,
       pessimisticFCP: fcp.pessimisticEstimate.timeInMs,
 
-      roughEstimateOfFMP: fmp.timing,
-      optimisticFMP: fmp.optimisticEstimate.timeInMs,
-      pessimisticFMP: fmp.pessimisticEstimate.timeInMs,
-
       roughEstimateOfTTI: tti.timing,
       optimisticTTI: tti.optimisticEstimate.timeInMs,
       pessimisticTTI: tti.pessimisticEstimate.timeInMs,

core/computed/metrics/timing-summary.js

@@ -9,7 +9,6 @@ import {ProcessedNavigation} from '../processed-navigation.js';
 import {Speedline} from '../speedline.js';
 import {FirstContentfulPaint} from './first-contentful-paint.js';
 import {FirstContentfulPaintAllFrames} from './first-contentful-paint-all-frames.js';
-import {FirstMeaningfulPaint} from './first-meaningful-paint.js';
 import {LargestContentfulPaint} from './largest-contentful-paint.js';
 import {LargestContentfulPaintAllFrames} from './largest-contentful-paint-all-frames.js';
 import {Interactive} from './interactive.js';
@@ -51,7 +50,6 @@ class TimingSummary {
     const speedline = await Speedline.request(trace, context);
     const firstContentfulPaint = await requestOrUndefined(FirstContentfulPaint, metricComputationData);
     const firstContentfulPaintAllFrames = await requestOrUndefined(FirstContentfulPaintAllFrames, metricComputationData);
-    const firstMeaningfulPaint = await requestOrUndefined(FirstMeaningfulPaint, metricComputationData);
     const largestContentfulPaint = await requestOrUndefined(LargestContentfulPaint, metricComputationData);
     const largestContentfulPaintAllFrames = await requestOrUndefined(LargestContentfulPaintAllFrames, metricComputationData);
     const interactive = await requestOrUndefined(Interactive, metricComputationData);
@@ -74,8 +72,6 @@ class TimingSummary {
       firstContentfulPaintTs: firstContentfulPaint?.timestamp,
       firstContentfulPaintAllFrames: firstContentfulPaintAllFrames?.timing,
       firstContentfulPaintAllFramesTs: firstContentfulPaintAllFrames?.timestamp,
-      firstMeaningfulPaint: firstMeaningfulPaint?.timing,
-      firstMeaningfulPaintTs: firstMeaningfulPaint?.timestamp,
       largestContentfulPaint: largestContentfulPaint?.timing,
       largestContentfulPaintTs: largestContentfulPaint?.timestamp,
       largestContentfulPaintAllFrames: largestContentfulPaintAllFrames?.timing,
@@ -107,8 +103,6 @@ class TimingSummary {
       observedFirstContentfulPaintTs: processedNavigation?.timestamps.firstContentfulPaint,
       observedFirstContentfulPaintAllFrames: processedNavigation?.timings.firstContentfulPaintAllFrames,
       observedFirstContentfulPaintAllFramesTs: processedNavigation?.timestamps.firstContentfulPaintAllFrames,
-      observedFirstMeaningfulPaint: processedNavigation?.timings.firstMeaningfulPaint,
-      observedFirstMeaningfulPaintTs: processedNavigation?.timestamps.firstMeaningfulPaint,
       observedLargestContentfulPaint: processedNavigation?.timings.largestContentfulPaint,
       observedLargestContentfulPaintTs: processedNavigation?.timestamps.largestContentfulPaint,
       observedLargestContentfulPaintAllFrames: processedNavigation?.timings.largestContentfulPaintAllFrames,

core/config/default-config.js

@@ -152,7 +152,6 @@ const defaultConfig = {
     'viewport',
     'metrics/first-contentful-paint',
     'metrics/largest-contentful-paint',
-    'metrics/first-meaningful-paint',
     'metrics/speed-index',
     'screenshot-thumbnails',
     'final-screenshot',
@@ -388,7 +387,6 @@ const defaultConfig = {
         // These are our "invisible" metrics. Not displayed, but still in the LHR.
         {id: 'interactive', weight: 0, group: 'hidden', acronym: 'TTI'},
         {id: 'max-potential-fid', weight: 0, group: 'hidden'},
-        {id: 'first-meaningful-paint', weight: 0, acronym: 'FMP', group: 'hidden'},
 
         {id: 'render-blocking-resources', weight: 0, group: 'diagnostics'},
         {id: 'uses-responsive-images', weight: 0, group: 'diagnostics'},