-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package namespace from rbmViz
to gsmViz
and add group attributes to all modules.
#430
Open
samussiah
wants to merge
15
commits into
dev
Choose a base branch
from
rename
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthegeek
reviewed
Feb 27, 2025
uses: JamesIves/github-pages-deploy-action@v4 | ||
with: | ||
folder: examples | ||
token: ${{ secrets.GH_PAGES_DEPLOY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To rough out the "multi deploy" idea:
- Set a target folder based on trigger type, like I do in the shinyapps deploy workflow.
- Use that to set the
target-folder:
variable for thiswith
. Use PR-level folders for PRs, and then probably adev
(in addition to the root formain
). - We should also have an action to delete those PR folders when the PRs are closed, like I do with the shinyapps terminate workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes visible on the
gh-pages
deployment: https://gilead-biostats.github.io/gsm.viz/gh-pages
action is failing. #409rbmViz
togsmViz
. #428