Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Res lake hq #250

Merged
merged 8 commits into from
Mar 29, 2023
Merged

Res lake hq #250

merged 8 commits into from
Mar 29, 2023

Conversation

verseve
Copy link
Contributor

@verseve verseve commented Mar 20, 2023

No description provided.

shartgring and others added 7 commits March 15, 2023 15:29
 - add maxstorage variable to lakes
- maximum_storage function: missing if no hq-table
- next step: add overflow
- Add maxstorage and adjust testsets
- Begin with new testset
- Validated values with hand calculation
- Includes overflow, sh and hq tables
- Overflow included
- Fixed incorrect if-statement for storfunc
Regulated lakes are also possible.
@verseve verseve linked an issue Mar 20, 2023 that may be closed by this pull request
@verseve verseve requested a review from JoostBuitink March 20, 2023 16:23
Copy link
Contributor

@JoostBuitink JoostBuitink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and nice addition to the code!

@verseve verseve merged commit 1c5ae83 into master Mar 29, 2023
@verseve verseve deleted the res-lake-hq branch March 29, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HQ approach for reservoirs
4 participants