Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HQ approach for reservoirs #242

Closed
verseve opened this issue Jan 20, 2023 · 2 comments · Fixed by #250
Closed

HQ approach for reservoirs #242

verseve opened this issue Jan 20, 2023 · 2 comments · Fixed by #250
Assignees
Labels
routing Feature or improvement related to the routing (or horizontal component)

Comments

@verseve
Copy link
Contributor

verseve commented Jan 20, 2023

Add SQ (volume based) approach based on thesis work about the Rur catchment in Germany. An HQ and SH approach already exists for the lakes. This is probably also a good moment to merge the Wflow lake and reservoir functionality.

@verseve verseve added the routing Feature or improvement related to the routing (or horizontal component) label Jan 20, 2023
@verseve verseve assigned verseve and shartgring and unassigned verseve Jan 20, 2023
@shartgring shartgring linked a pull request Feb 28, 2023 that will close this issue
@verseve
Copy link
Contributor Author

verseve commented Feb 28, 2023

Comment from @shartgring :
We first discussed this implementation through modelling the reservoirs as lakes, and adding a new LakeOutflowFunc for the SQ-approach. However, it is also possible by adding the functionality to the reservoirs

ResOutflowFunc is determined by checking if .csv file corresponding to reservoir exists. If it exists, the reservoir will use the SQ-approach. If not, then it is modelled using the old approach. It is a 'quick fix', but I would say it is a good alternative until lakes and reservoirs are merged into 'waterbody'. Advantage of this fix is that it uses parameters such as ResMaxVolume which are generated by hydromt_wflow, and that it will work with previous Wflow models (no breaking).

Code passed tests and 2 new tests are added, for normal flow and for a overflowing reservoir. Results correspond with hand calculations. Attached the csv file used in the test, maybe nice to upload to artifact repo if this will be implemented

res_sq_1.csv

@verseve verseve changed the title SQ approach for reservoirs HQ approach for reservoirs Mar 20, 2023
@verseve
Copy link
Contributor Author

verseve commented Mar 20, 2023

After some discussion we decided to use the existing functionality as part of the Lake module (HQ approach), and add overflow here, to keep the code simple and to avoid (partly) duplication of code. A lake with a rating curve of type 1 (HQ table) is a regulated lake/ dam. Also, for now we keep the reservoir and lake functionality separate, merging is still an option, and can be part of another PR (need to think more about implications for Wflow.jl as well as hydromt_wflow).

@verseve verseve removed a link to a pull request Mar 20, 2023
@verseve verseve linked a pull request Mar 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
routing Feature or improvement related to the routing (or horizontal component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants