-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HQ approach for reservoirs #242
Comments
Comment from @shartgring : ResOutflowFunc is determined by checking if .csv file corresponding to reservoir exists. If it exists, the reservoir will use the SQ-approach. If not, then it is modelled using the old approach. It is a 'quick fix', but I would say it is a good alternative until lakes and reservoirs are merged into 'waterbody'. Advantage of this fix is that it uses parameters such as ResMaxVolume which are generated by hydromt_wflow, and that it will work with previous Wflow models (no breaking). Code passed tests and 2 new tests are added, for normal flow and for a overflowing reservoir. Results correspond with hand calculations. Attached the csv file used in the test, maybe nice to upload to artifact repo if this will be implemented |
After some discussion we decided to use the existing functionality as part of the Lake module (HQ approach), and add overflow here, to keep the code simple and to avoid (partly) duplication of code. A lake with a rating curve of type 1 (HQ table) is a regulated lake/ dam. Also, for now we keep the reservoir and lake functionality separate, merging is still an option, and can be part of another PR (need to think more about implications for Wflow.jl as well as hydromt_wflow). |
Add SQ (volume based) approach based on thesis work about the Rur catchment in Germany. An HQ and SH approach already exists for the lakes. This is probably also a good moment to merge the Wflow lake and reservoir functionality.
The text was updated successfully, but these errors were encountered: