Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite gradle.properties with CI configs for test plugin task #316

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

ambushwork
Copy link
Member

What does this PR do?

test:plugin keeps failing on CI with this error:

> Task :dd-sdk-android-gradle-plugin:test
DdAndroidGradlePluginFunctionalTest > M success W assembleRelease() FAILED
    java.lang.IllegalStateException at DdAndroidGradlePluginFunctionalTest.kt:142
        Caused by: org.gradle.tooling.GradleConnectionException at DdAndroidGradlePluginFunctionalTest.kt:142
            Caused by: org.gradle.launcher.daemon.client.DaemonDisappearedException at DaemonClient.java:283
DdAndroidGradlePluginFunctionalTest > M not try to upload the symbol file W no cmake dependencies { using a fake API_KEY }() FAILED
    java.lang.IllegalStateException at DdAndroidGradlePluginFunctionalTest.kt:1022
        Caused by: org.gradle.tooling.GradleConnectionException at DdAndroidGradlePluginFunctionalTest.kt:1022
            Caused by: org.gradle.launcher.daemon.client.DaemonDisappearedException at DaemonClient.java:283

For CI it's useless to have daemons, so we copy the CI gradle properties to the overwrite the project gradle properties with following options:

org.gradle.daemon=false
org.gradle.parallel=false
org.gradle.caching=false

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (b6c619f) to head (fce8c51).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #316      +/-   ##
=============================================
- Coverage      78.11%   77.90%   -0.21%     
+ Complexity       261      258       -3     
=============================================
  Files             31       31              
  Lines            941      941              
  Branches         113      113              
=============================================
- Hits             735      733       -2     
  Misses           151      151              
- Partials          55       57       +2     

see 1 file with indirect coverage changes

@ambushwork ambushwork marked this pull request as ready for review February 25, 2025 14:35
@ambushwork ambushwork requested review from a team as code owners February 25, 2025 14:35
@ambushwork ambushwork merged commit 11e01a4 into develop Feb 25, 2025
12 checks passed
@ambushwork ambushwork deleted the yl/fix-test-plugin-ci branch February 25, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants