Merge develop into feature/kotlin-compiler-plugin #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwrite gradle.properties with CI configs for test plugin task
0xnm
reviewed
Feb 26, 2025
.gitlab-ci.yml
Outdated
| @@ -90,6 +90,7 @@ test:plugin: | |||
| stage: test | |||
| timeout: 1h | |||
| script: | |||
| - aws ssm get-parameter --region us-east-1 --name ci.dd-sdk-android-gradle-plugin.gradle-properties --with-decryption --query "Parameter.Value" --out text >> ./gradle.properties | |||
There was a problem hiding this comment.
I read that it is coming from #316, but I'm not sure why do we need to store Gradle Properties in SSM and not simply use run flags for CI (like we do with --no-daemon already).
You can have all flags defined in the env variable for this job and simply read it from there when running Gradle task.
There was a problem hiding this comment.
develop branch is updated
Increase CI kubernetes memory limit to 20Gi to avoid OOM
0xnm
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge develop into feature/kotlin-compiler-plugin
Review checklist (to be filled by reviewers)