-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/additional themes #540
Conversation
code light and smyck light are not usable right now. I have to tune highlighting and maybe some colors |
now we're good. |
An initial visual check of the themes shows that they all look amazing! 💯 There is a little bug if there's no theme selected, yet: The danger of checking against Of course, we can fix the issue inline in this PR. But my hunch in #534 (comment) that the lack of a default |
I looked into it a bit more. It was a good hunch at #534 (comment), indeed. |
I thought I had covered all the bases by checking against undefined AND "undefined" (as a string). Something else that just came to mind: |
4294521
to
27c1771
Compare
I rebased, removed the check for 'undefined' and added a default value for theme. |
27c1771
to
e5fd039
Compare
@tarnung Really good work! I've added contribution to the changelog and added a section to the documentation, because this is too pretty to leave it off the docs(; |
#539