Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Actually use and persist default settings #553

Merged
merged 5 commits into from
Nov 1, 2020
Merged

fix: Actually use and persist default settings #553

merged 5 commits into from
Nov 1, 2020

Conversation

munen
Copy link
Collaborator

@munen munen commented Nov 1, 2020 •
edited
Loading

Based on #552

munen added 5 commits November 1, 2020 19:50
@munen
test: Settings persister does not persist falsy values
66e4b66
@munen
fix: Settings that are falsy should not be persisted
b42e9c0 
     Before, we were persisting settings like:

     ```
     localStorage.getItem("colorScheme")
     "undefined"
     ```

     The defaults still don't work, but they at least aren't crazy
     like above:

     ```
     localStorage.getItem("colorScheme")
     null
     ```
@munen
fix: Partial fix for not having a default color scheme
c539b3b
@munen
test: Actually use and persist default settings
24eb5ab
@munen
fix: Actually use and persist default settings
d00e949
@munen munen changed the title Fix/settings persistance 2 fix: Actually use and persist default settings Nov 1, 2020
@munen munen mentioned this pull request Nov 1, 2020
Merged
@munen
Copy link
Collaborator Author

munen commented Nov 1, 2020

@tarnung This should help regarding the issue we discussed in #534 and #540. Once merged, I propse to merge master into your PRs.

@munen munen merged commit d00e949 into master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@munen