Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from mypy_extensions to typing_extensions #769

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Aug 10, 2020

This requires the PyPy build to be upgraded due to a failure in earlier PyPy versions.

This also upgrades the mypy we test against - this doesn't require any changes, however.

@neiljp neiljp added this to the Next Release milestone Aug 10, 2020
@neiljp neiljp requested a review from kaustubh-nair August 10, 2020 16:36
@zulipbot zulipbot added the size: S [Automatic label added by zulipbot] label Aug 10, 2020
neiljp added 3 commits August 10, 2020 09:40
PyPy 7.3.1 is required to work around a bug with using
typing_extensions.TypedDict.
https://foss.heptapod.net/pypy/pypy/-/issues/3278

PyPy 7.3.1 is only available for PyPy >=3.6.
TypedDict requires an external module until Python 3.8;
typing-extensions is a newer equivalent of mypy-extensions that contains
types likely to be incorporated into typing in future version of Python.
@neiljp neiljp force-pushed the 2020-08-09-typing-extensions branch from 63e6dc2 to 8105f6e Compare August 10, 2020 16:41
Copy link
Member

@kaustubh-nair kaustubh-nair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good to me!

@neiljp neiljp merged commit c470d25 into zulip:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants