Support footlinks configuration via zuliprc #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
reviewed
Jul 24, 2020
There was a problem hiding this comment.
@preetmishra I've not tried this yet, though it reads OK - could you add some tests?
I did post in the stream about this though, since while we did mention adding configurability, I wonder if we should wait to hear what users think first?
This adds support for configuring footlinks view in MessageBox (defaults to 'enabled') via zuliprc. README updated with instructions. Test added and amended.
preetmishra
force-pushed
the
feat-footlinks-zuliprc-config
branch
from
be8be27 to
e52c2f7
Compare
zulipbot
added
size: M
|
@neiljp Thanks for taking a look. I have pushed the tests. Yeah, let's wait for some feedback. |
preetmishra
added
the
further discussion required
|
@preetmishra As per discussion in-stream, I'm merging this now - thanks for this! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for configuring footlinks view in MessageBox (defaults to 'enabled') via zuliprc.
README updated with instructions.
Tests amended.