Upgrade dependencies (install, dev, linting, dev_helper) #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may require extra development documentation due to jorisroovers/gitlint#250, which applies for upgrades.
These are upgraded simultaneously due to a co-dependence upon `pycodestyle`.
Other than general improvements, this enables extra themes, including the gruvbox theme directly, which should simplify our syntax highlighting.
These API types were originally in zulip-terminal, but were migrated to the python API since they have use more generally.
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
neiljp
added
the
PR ready to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This bumps the versions of many of the project's dependencies.
Most of the install dependencies provide extra features or bugfixes, with the addition that the zulip package now incorporates some code that was previously defined locally so that can be refactored out. The only downside of the latter is that this is less explicit in our code, hence the minor additional comments.
Other than bumping linting dependencies generally, the upgraded
mypywill allow for improving our use ofTypedDict, among other possibilities. Additional typing dependencies should help; we could consider one forbeautifulsoup4, but this requires further analysis so I've left it at this time.Tested?
There should not be any significant feature changes in the dependencies, so I expect tests to pass fine.
Notes & Questions
The change to gitlint may require an uninstall and reinstall. I've not made an update to the documentation regarding this (at least yet) as existing developers tend to be involved on chat.zulip.org, where I'll raise this point.
Potential follow-up:
beautifulsoup4TypedDictwithtotal=False)