Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up button causes crash on muted streams. #272

Closed
sumanthvrao opened this issue Jan 21, 2019 · 10 comments
Closed

Up button causes crash on muted streams. #272

sumanthvrao opened this issue Jan 21, 2019 · 10 comments
Assignees
@sumanthvrao
Labels
bug Something isn't working in progress

Comments

@sumanthvrao
Copy link
Member

Steps to reproduce issue:

  1. Mute stream bot testing on czo.
  2. Access stream in ztto find contents cleared for that stream.
  3. Using the 'Up'/k HotKey causes the exception.

Traceback of error:
error
@neiljp neiljp mentioned this issue Jan 21, 2019
Closed
@neiljp neiljp added the bug Something isn't working label Jan 21, 2019
@vva2
Copy link

vva2 commented Jan 21, 2019

I don't know why but i couldn't reproduce the error following the steps @sumanthvrao suggested instead it shows a blank screen in the chat area ,same as said by @rht in #236.

@vva2
Copy link

vva2 commented Jan 21, 2019 •
edited
Loading

And that mute is not working properly in zt ,it just shows blank screen.

@sumanthvrao
Copy link
Member Author

I was unable to produce this in my development env. But by muting stream in czo as described in steps above, i was indeed able to reproduce it. Which one are you trying @vishal-vardhan ?

@vva2
Copy link

vva2 commented Jan 24, 2019 •
edited
Loading

@sumanthvrao sorry i got late.yes i did the same thing as u did.moreover i don't think we can mute a stream in zt.

@sumanthvrao
Copy link
Member Author

@vishal-vardhan I just muted it in the web-client and then checked it in zt

@sumanthvrao
Copy link
Member Author

@vishal-vardhan are you still working on this?

@sumanthvrao
Copy link
Member Author

@zulipbot claim

@sumanthvrao
Copy link
Member Author

@neiljp This issue no longer seems to occur. Trying to press Up/k HotKey in recent version of master is not causing a crash. Testing with the most recent version of master here.

@sumanthvrao
Copy link
Member Author

sumanthvrao commented Feb 20, 2019 •
edited
Loading

Further discussion on this issue is here.
https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Muted.20streams/near/701605

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 26, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
552fe9c 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests changed to patch muted_setup call.

Fixes: zulip#272, zulip#236
@sumanthvrao sumanthvrao mentioned this issue Feb 26, 2019
Closed
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 26, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
685091a 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests amended.

Fixes: zulip#272, zulip#236
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 27, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
8eb9a79 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests amended.

Fixes: zulip#272, zulip#236
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 28, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
225ed89 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests amended.

Fixes: zulip#272, zulip#236
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 1, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
1325090 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests amended.

Fixes: zulip#272, zulip#236
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 3, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
f5477bd 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests amended.

Fixes: zulip#272, zulip#236
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 4, 2019
@sumanthvrao
buttons: Mark muted streams during button creation.
a6c8d7e 
Before we used to set stream as muted based on unread messages.
On startup this caused no stream to be marked as 'M'.
Now, we mark them as muted during button creation.

Tests amended.

Fixes: zulip#272, zulip#236
@neiljp neiljp closed this as completed in 1fae27c Mar 4, 2019
@neiljp
Copy link
Collaborator

neiljp commented Mar 4, 2019

Thanks to @sumanthvrao for their work on this! This should be resolved since we now show the content of muted streams, except if in the all-messages narrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumanthvrao sumanthvrao

Labels
bug Something isn't working in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issues regarding muted streams. sumanthvrao/zulip-terminal
4 participants
@neiljp @zulipbot @sumanthvrao @vva2